Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop to Main #200

Closed
wants to merge 419 commits into from
Closed

Develop to Main #200

wants to merge 419 commits into from

Conversation

livingrockrises
Copy link
Contributor

Summary

Related Issue: # (issue number)

Change Type

  • Bug Fix
  • Refactor
  • New Feature
  • Breaking Change
  • Documentation Update
  • Performance Improvement
  • Other

Checklist

  • My code follows this project's style guidelines
  • I've reviewed my own code
  • I've added comments for any hard-to-understand areas
  • I've updated the documentation if necessary
  • My changes generate no new warnings
  • I've added tests that prove my fix is effective or my feature works
  • All unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Additional Information

Branch Naming

livingrockrises and others added 30 commits November 1, 2023 16:29
@livingrockrises
refactor
59bf1c2
minor rename
b783a56
Merge branch 'features/Improve-readability-for-Batched-Session-Router…
3b1009d 
…-Tests' of https://github.com/bcnmy/scw-contracts into features/Improve-readability-for-Batched-Session-Router-Tests
@ankurdubey521
Merge branch 'develop' into features/sma-195-security-policy
ba215e8
🎨 fix typos
9942351
@ankurdubey521
update registry dep
6e302b0
@ankurdubey521
bump solidity version to 0.8.20
ee59e20
@ankurdubey521
feat: checkAndEnableModule and verify if module is a contract during …
b417990 
…installation
@ankurdubey521
feat: ERC7484SecurityPolicyPlugin
e1c11ee
@Aboudjem
🔒️ update readme file to include audits
0b9f621
@Aboudjem
📝 add audit reports
e1cf9a4
@Aboudjem
🚚 rename file using spaces instead of _
873e83e
@Aboudjem
Merge pull request #166 from bcnmy/features/SMA-253-add-audits
0ed1777 
Features/sma 253 add audits
@ankurdubey521
feat: remove dependence on via-ir for compilation
9458286
@ankurdubey521
Add tests and configuration for forge coverage
ac0de97
@AmanRaj1608
remove commented code
ff3d258
@ankurdubey521
fixes for #150
0b1d929
@ankurdubey521
optimise checkSetupAndEnableModule
dd2d0ff
@ankurdubey521
optimise __validateSecurityPolicies
c695f4c
@ankurdubey521
test: Security Policy Plugin: Module Installation
b2a7d1b
@ankurdubey521
optimise checkAndEnableModule
09f38ac
@ankurdubey521
remove memory safe annotations
2831008
@AmanRaj1608
fix: cryptography audit fixes
f7e03db
@AmanRaj1608
lint fix
bb81207
@filmakarov
Merge pull request #165 from bcnmy/features/Improve-readability-for-B…
ac1b061 
…atched-Session-Router-Tests

Improve readability for batched session router tests
additional check for outer callData
f9be1c6
adding SA address to control message
25bea17
remove unnecessary condition
e9829ca
@ankurdubey521
Switch to /** */ style of natspecs from ///
fc75630
remove condition
b44b79d
Filipp Makarov and others added 24 commits January 17, 2024 12:15
remove draft report
b5a721f
@Aboudjem
➕ add Secp256r1 + passkey / skm final reports
d09e286
@Aboudjem
Rename Biconomy Secp256r1 - Zellic Audit Report Final.pdf to Biconomy…
353f54e 
… Secp256r1 - Zellic Audit Report.pdf
@livingrockrises
Merge pull request #190 from bcnmy/feat/Add-Acc-Recovery-Audit2-Multi…
5e97846 
…-Owned-ECDSA-reports

Add Account Recovery Audit pt2 and Multi-owned ECDSA reports
selfauthorize remove
036c11a
type fix for event
2acd121
changes upon review
cdc7cef
natspec fix
ef0053c
isContract=>lib function
b78c27c
bytes32=>uint160=>address conversion for destContract
6de8982
introduce max usage
f0b53b1
add test for maxUsage
805aa9b
add isValidSignatureForAddressUnsafe and natspecs
34a75fa
change way of providing userOp.sender
1a11bd4
fix tests
a5ac5a4
@filmakarov
Merge pull request #197 from bcnmy/feat/SMA-378-379-ABI-SVM-Audit-Rem…
dddc887 
…ediations

SMA 379 ABI SVM audit remediations pt 1
Merge branch 'develop' into feat/SMA-363-ABI-SVM
0d4251f
add audit reports
c2831e5
add Kawach report
73dcb23
@filmakarov
Merge pull request #174 from bcnmy/feat/SMA-363-ABI-SVM
fbd8360 
Merging the module to the develop branch
@filmakarov
Merge pull request #196 from bcnmy/feat/SMA-234-Aggregated-audit-reme…
21c9ff6 
…diations

Aggregated Audit Remediations
@ankurdubey521
Merge branch 'develop' into feat/sma-392-session-keys-v2
c3fe846
@ankurdubey521
feat: Kawach Audit for SKMv2
50ccc11
@ankurdubey521
Merge pull request #180 from bcnmy/feat/sma-392-session-keys-v2
3362262 
SMA-392: Session Keys V2
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 6, 2024

This PR has been inactive for 30 days. If it's waiting for a review, please reach out to the team. Otherwise, please update the PR or it will be closed due to inactivity.

@github-actions github-actions bot closed this Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filmakarov filmakarov Awaiting requested review from filmakarov

@ankurdubey521 ankurdubey521 Awaiting requested review from ankurdubey521

@Aboudjem Aboudjem Awaiting requested review from Aboudjem

Assignees
No one assigned
Labels
inactive-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@livingrockrises @ankurdubey521 @Aboudjem @AmanRaj1608 @filmakarov