Added Test Cases per Zellic audit questions

[filmakarov]

Summary

• In the BatchedSessionRouterModule, added a check to ensure that the decoded sessionData array contains enough elements for all the actions and corresponding tests
• For the ERC20SessionValidationModule, added tests to ensure it reverts when userOp.callData is too short or when the length for the inner bytes array is not correct

Related Issue: SMA-143, and SMA-144

Change Type

• Unit Tests
• Bug Fix

Checklist

• My code follows this project's style guidelines
• I've reviewed my own code
• I've added comments for any hard-to-understand areas
• I've updated the documentation if necessary
• My changes generate no new warnings
• I've added tests that prove my fix is effective or my feature works
• All unit tests pass locally with my changes
• Any dependent changes have been merged and published

P.S. The branch name is fix/ not /fixes because it was created before the discussion about naming convention. Next time will make it fixes/.

[linear]

SMA-143 Add length related checks to ERC20 SVM

> - In the ERC20SessionValidationModule, within the validateSessionUserOp function, should there be a check for the minimum length of _op.callData and a maximum length not exceeding 4 + offset + 32 + length?

I suppose, that the minimum length check is being done implicitly. if it is less then 4 bytes, the selector check will revert

if it is less than 68 bytes, decoding tokenAddr and callValue will fail. 

But you're right, that we maybe should add a test case to check that it definitely fails.

For the maximum length check, do you mean the case when the callData is some arbitrary data, not the correctly encoded one, and the length can be taken from some random bytes?

I think yes, maybe we need to test the behavior of ERC20 SVM in this case and see if the explicit check in the smart contract is needed or it still reverts in case of incorrectly encoded callData.

[ankurdubey521]

LGTM, but I think you need to fix a few linting errors

[filmakarov]

@ankurdubey521 @Aboudjem Sorry guys, it requires approvals from you again.
Next time will fix the linting first before requesting the reviews

[Aboudjem]

@ankurdubey521 @Aboudjem Sorry guys, it requires approvals from you again. Next time will fix the linting first before requesting the reviews

No worries ! the husky hook didn't work?

[filmakarov]

No worries ! the husky hook didn't work?

I skipped it initially :)