Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M sma 64 master #135

Closed
wants to merge 7 commits into from
Closed

M sma 64 master #135

wants to merge 7 commits into from

Conversation

livingrockrises
Copy link
Contributor

No description provided.

test/Smart-Account-Factory.specs.ts Outdated Show resolved Hide resolved
const blocksToWait = 10;
const currentBlockNumber = await ethers.provider.getBlockNumber();
const targetBlockNumber = currentBlockNumber + blocksToWait;
while ((await ethers.provider.getBlockNumber()) < targetBlockNumber) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using evm_increaseTime instead

test/Smart-Account-Factory.specs.ts Show resolved Hide resolved
test/Smart-Account-Factory.specs.ts Show resolved Hide resolved
@filmakarov
Copy link
Collaborator

@proxima424 @2Proxima4 What's the status here?

@Aboudjem
Copy link
Contributor

Closing this PR as there hasn't been any recent update and lack of necessary context, please refer to our guidelines👍:

Branch Naming Convention
Git Workflow: From Feature Dev to Prod Release
Gitmoji Commit Best Practices
Pull Requests (PRs).

@Aboudjem Aboudjem closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants