Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added check for entryPointAddress field #337

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Added check for entryPointAddress field #337

merged 2 commits into from
Dec 11, 2023

Conversation

VGabriel45
Copy link
Collaborator

Summary

Added conditional logic for situations when user will not provide "entryPointAddress" to the Bundler.

Related Issue: #

Change Type

  • Bug Fix
  • Refactor
  • New Feature
  • Breaking Change
  • Documentation Update
  • Performance Improvement
  • Other

Checklist

  • My code follows this project's style guidelines
  • I've reviewed my own code
  • I've added comments for any hard-to-understand areas
  • I've updated the documentation if necessary
  • My changes generate no new warnings
  • I've added tests that prove my fix is effective or my feature works
  • All unit tests pass locally with my changes
  • Any dependent changes have been merged and published

AmanRaj1608
AmanRaj1608 reviewed Dec 11, 2023
View reviewed changes
packages/bundler/src/utils/Constants.ts
@@ -125,3 +125,5 @@ export const UserOpWaitForTxHashMaxDurationIntervals: { [key in ChainId]?: numbe
[ChainId.CHILIZ_MAINNET]: 20000,
[ChainId.CHILIZ_TESTNET]: 20000,
};

export const DEFAULT_ENTRYPOINT_ADDRESS = "0x5ff137d4b0fdcd49dca30c7cf57e578a026d2789";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could also import this from the baseValidationModule, but this is also fine if we don't wanna have circular dependency

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's fine like this I'm gonna let it

AmanRaj1608
AmanRaj1608 suggested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@AmanRaj1608 AmanRaj1608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix lint issues

livingrockrises
livingrockrises approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@livingrockrises livingrockrises left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@livingrockrises livingrockrises merged commit f53dae0 into develop Dec 11, 2023
2 checks passed
@NunoFilipeSantos NunoFilipeSantos mentioned this pull request Dec 29, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@livingrockrises livingrockrises livingrockrises approved these changes

@AmanRaj1608 AmanRaj1608 AmanRaj1608 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VGabriel45 @AmanRaj1608 @livingrockrises @GabiDev45