bugfix/KBDEV-1254 New Records of Abstract Classes Unnecessarily Required Admin Permission #93
Conversation
bnguyen-bcgsc
commented
Sep 17, 2024
bnguyen-bcgsc
commented
- Fix bug in main view where new records of abstract classes (e.g.: ontology, relationship) required admin permission
- Fix rowData typos for ag grid calls
- Code lint
- Fix bug in main view where new records of abstract classes (e.g.: ontology, relationship) required admin permission - Fix rowData typos for ag grid calls - Code lint
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #93 +/- ##
========================================
Coverage 56.76% 56.76%
========================================
Files 102 102
Lines 3874 3874
Branches 1310 1310
========================================
Hits 2199 2199
Misses 1663 1663
Partials 12 12 ☔ View full report in Codecov by Sentry. |
|
I don't understand why we need a client code change while ticket describes a very recent behavior. Any idea @bnguyen-bcgsc or @elewis2 ? |
@mathieulemieux we suspect that it worked initially because they had not hard-refresh the client when the new version was released and the change was made using 4.2.3. After examining the behaviour and recreating the issue, line 110 of MainView was determined to be the cause of the problem |
|
@bnguyen-bcgsc, was the issue reported on prod? because last update was more than 2y ago... |
|
Maybe the deployed version was still 4.2.3 though... I think we documented that issue before, so if it's the case, then it's start to make sense. |
I don't believe so since the change that caused the issue was added in just 6 months ago |
