Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[helm] Remove not function, cleanup definitions #620

Merged
merged 2 commits into from
Sep 13, 2024
Merged

[helm] Remove not function, cleanup definitions #620

merged 2 commits into from
Sep 13, 2024

Conversation

i5okie
Copy link
Contributor

@i5okie i5okie commented Sep 3, 2024

Remove not function from, and cleanup helpers.
This should resolve the issue of installing the vc-authn-oidc chart as a dependency of another chart.

@i5okie i5okie requested a review from esune September 3, 2024 22:31
@i5okie i5okie self-assigned this Sep 3, 2024
esune
esune reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens to the chart when postgresql is enabled (i.e.: the condition is not being checked anymore)? Change itself is trivial enough

@esune esune merged commit 5249b32 into main Sep 13, 2024
2 checks passed
@esune esune deleted the feat/helm-chart-fix branch September 13, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esune esune esune approved these changes

@WadeBarnes WadeBarnes Awaiting requested review from WadeBarnes

@loneil loneil Awaiting requested review from loneil

Assignees

@i5okie i5okie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i5okie @esune