Fix subscriptions #2261
Merged
Fix subscriptions #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fosol
added
bug
Fosol
commented
Sep 5, 2024
| </Col> | ||
| <Col flex="2"> | ||
| <p> | ||
| If this user is currently subscribed through a distribution list, you will need to |
There was a problem hiding this comment.
Just a warning as the code will take a lot longer to write.
| @@ -192,3 +178,39 @@ export const MyProducts: React.FC = () => { | |||
| </styled.MyProducts> | |||
| ); | |||
| }; | |||
|
|
|||
| const modalBody = (active: ISelectedProduct) => { | |||
There was a problem hiding this comment.
Fixed text based on status. This all got messy due to distribution lists.
| this.IsSubscribed = subscription?.IsSubscribed ?? false; | ||
| } | ||
| else if (entity.Product.ProductType == Entities.ProductType.EveningOverview) | ||
| { | ||
| var subscription = entity.User.AVOverviewSubscriptionsManyToMany | ||
| .FirstOrDefault(s => s.UserId == entity.UserId && | ||
| (int)s.TemplateType == entity.Product!.TargetProductId); | ||
| .FirstOrDefault(s => s.IsSubscribed && (int)s.TemplateType == entity.Product!.TargetProductId); |
There was a problem hiding this comment.
I don't love this, but since a user can be subscribed through a distribution list it's currently necessary.
| @@ -109,15 +110,13 @@ public UserProductModel(Entities.UserProduct entity) : base(entity) | |||
| else if (entity.Product.ProductType == Entities.ProductType.Notification) | |||
| { | |||
| var subscription = entity.User.NotificationSubscriptionsManyToMany | |||
| .FirstOrDefault(s => s.UserId == entity.UserId && | |||
| s.NotificationId == entity.Product!.TargetProductId); | |||
| .FirstOrDefault(s => s.IsSubscribed && s.NotificationId == entity.Product!.TargetProductId); | |||
There was a problem hiding this comment.
I don't love this, but since a user can be subscribed through a distribution list it's currently necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing various issues related to subscriptions through a distribution list.