Fix report charts #2241
Merged
Fix report charts #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fosol
added
bug
Fosol
commented
Aug 30, 2024
| @@ -45,7 +45,7 @@ export const ReportSectionMediaAnalytics = React.forwardRef< | |||
| <Show visible={!values.template?.chartTemplates.length}> | |||
| <p className="error"> | |||
| This template does not currently support charts. Update the template and add the charts it | |||
| supports. | |||
| supports. Save your report first to apply the template. | |||
There was a problem hiding this comment.
Improve user experience with more information.
| @@ -65,7 +65,11 @@ export const ReportSectionMediaAnalyticsChart = React.forwardRef< | |||
| }, [section, chart, reportContent, showReportData, testData, values.sections]); | |||
|
|
|||
| React.useEffect(() => { | |||
| setReportContent(values.instances ? values.instances[0].content : []); | |||
| setReportContent( | |||
There was a problem hiding this comment.
Fixed critical bug in charts.
| @@ -141,7 +141,17 @@ export const ChartViewer: React.FC<IChartViewerProps> = ({ | |||
| return ( | |||
| <div> | |||
| <div> | |||
| <canvas ref={canvasRef} id={`my-chart-${uid}`} /> | |||
| <Show visible={!data?.labels.length}> | |||
There was a problem hiding this comment.
Direct user on how to get chart to display report data.
| @@ -60,6 +60,10 @@ export const ConfigureDataset: React.FC<IChartSectionProps> = ({ sectionIndex, c | |||
| isSentiment && chart.sectionSettings.dataset === '' | |||
| ? ['green', 'gold', 'red'] | |||
| : [], | |||
| datasetBorderColors: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issue Scott was having in PROD.
Added information message to direct user to regenerate the report/section to pull in content.