Fix report charts #2239
Merged
Fix report charts #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fosol
added
bug
Fosol
commented
Aug 30, 2024
| @@ -90,7 +90,7 @@ export const Modal: React.FC<IModalProps> = ({ | |||
| <Button | |||
| variant={type === 'delete' ? 'error' : 'primary'} | |||
| onClick={onConfirm} | |||
| disabled={isSubmitting && !enableConfirm} | |||
| disabled={isSubmitting || !enableConfirm} | |||
There was a problem hiding this comment.
If either then disable. The way this was implemented didn't make sense. I hope where ever else it's used it doesn't break.
| @@ -156,6 +156,9 @@ export const ReportEditContentForm = React.forwardRef< | |||
| }} | |||
| /> | |||
| </Show> | |||
| <Show visible={isSubmitting}> | |||
| <Loading /> | |||
There was a problem hiding this comment.
The regenerate process takes a bit.
| setData(convertToChart(chart, showReportData ? reportContent : testData, values.sections)); | ||
| }, [chart, reportContent, showReportData, testData, values.sections]); | ||
| const sectionContent = | ||
| section.filterId || section.folderId || section.linkedReportId |
There was a problem hiding this comment.
Only include content in the section when appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue with charts that should only display the content in their own section.
Fixed issue with regenerate report and charts.
Fixed modal disable confirm button.