18730 - Add invoice id to EJV description, because it doesn't show up in flow thr…

[seeker25]

…ough.

bcgov/entity#18730

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

[codecov]

Codecov Report

Merging #1327 (c07dc62) into main (79924ce) will decrease coverage by 4.42%.
Report is 45 commits behind head on main.
The diff coverage is 93.50%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1327      +/-   ##
==========================================
- Coverage   91.45%   87.04%   -4.42%     
==========================================
  Files         186       40     -146     
  Lines       11319     2987    -8332     
==========================================
- Hits        10352     2600    -7752     
+ Misses        967      387     -580     

Flag	Coverage Δ
bcolapi	?
eventlistenerqueue	?
payapi	?
paymentjobs	83.01% <91.78%> (+2.78%)	⬆️
paymentreconciliationsqueue	92.42% <94.05%> (+0.97%)	⬆️
reportapi	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
jobs/payment-jobs/tasks/common/dataclasses.py	100.00% <100.00%> (ø)
jobs/payment-jobs/tasks/common/enums.py	100.00% <ø> (ø)
jobs/payment-jobs/tasks/distribution_task.py	97.75% <100.00%> (ø)
...ayment-jobs/tasks/ejv_partner_distribution_task.py	99.15% <100.00%> (+0.02%)	⬆️
jobs/payment-jobs/tasks/ejv_payment_task.py	96.55% <100.00%> (+0.09%)	⬆️
.../payment-jobs/tasks/statement_notification_task.py	79.74% <100.00%> (+47.92%)	⬆️
...iations/src/reconciliations/cgi_reconciliations.py	93.38% <100.00%> (+0.02%)	⬆️
...ment-reconciliations/src/reconciliations/config.py	96.47% <100.00%> (+0.08%)	⬆️
...econciliations/src/reconciliations/eft/__init__.py	100.00% <100.00%> (ø)
...conciliations/src/reconciliations/eft/eft_enums.py	100.00% <100.00%> (ø)
... and 14 more

... and 157 files with indirect coverage changes

[ochiu]

@seeker25 I noticed a few of the statement tests were erroring. I re-ran the check this morning and it passed.

I did some investigation it seemed like maybe a date time comparison issue. I will take a look at the statement jobs as I am currently working in there already.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication