Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various bug fixes and updated data migrations #243

Merged
merged 6 commits into from
Dec 14, 2023
Merged

Various bug fixes and updated data migrations #243

merged 6 commits into from
Dec 14, 2023

Conversation

JustinMacaulay
Copy link
Contributor

Updated all of the migrations to handle new data and tables. Various bug fixes from the week.

@github-actions GitHub Actions
Copy link

rsbc-roadside-forms-backend-api:latest (redhat 8.8) - Trivy Report - 2023-12-14 20:40:30.26568335 +0000 UTC m=+0.271437721

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

sam-warren
sam-warren approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@sam-warren sam-warren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

roadside-forms-frontend/frontend_web_app/src/components/CommonForm/driverInfo.js Outdated
@@ -256,9 +273,12 @@ export const DriverInfo = (props) => {
<Col sm={4}>
<SearchableSelect
className="field-height field-width"
label="Province / State"
label="Province / State/ International"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Missing space after "State" before "/"

@github-actions GitHub Actions
Copy link

rsbc-roadside-forms-backend-api:latest (redhat 8.8) - Trivy Report - 2023-12-14 20:57:35.18292193 +0000 UTC m=+0.277988918

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

@github-actions GitHub Actions
Copy link

rsbc-roadside-forms-backend-api:latest (redhat 8.8) - Trivy Report - 2023-12-14 20:58:04.581064878 +0000 UTC m=+0.264680178

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

@github-actions GitHub Actions
Copy link

rsbc-roadside-forms-backend-api:latest (redhat 8.8) - Trivy Report - 2023-12-14 21:12:12.365458528 +0000 UTC m=+0.278359248

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

@github-actions GitHub Actions
Copy link

rsbc-roadside-forms-backend-api:latest (redhat 8.8) - Trivy Report - 2023-12-14 21:14:36.948055263 +0000 UTC m=+0.286103227

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

@github-actions GitHub Actions
Copy link

rsbc-roadside-forms-backend-api:latest (redhat 8.8) - Trivy Report - 2023-12-14 21:28:06.551210763 +0000 UTC m=+0.266689233

redhat
No Vulnerabilities found
No Misconfigurations found
python-pkg
No Vulnerabilities found
No Misconfigurations found

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)
11.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@JustinMacaulay JustinMacaulay merged commit 89eb3fa into release/1.0 Dec 14, 2023
3 of 9 checks passed
@JustinMacaulay JustinMacaulay deleted the bug/various-bug-fixes branch December 14, 2023 21:30
amlanc1 added a commit that referenced this pull request Mar 19, 2024
@JustinMacaulay @sam-warren
@amlanc1 @david-kerins
Release/1.0 (#189)
90b64d7 
* more verbose error

* Add form spoiling functionality

* spoil form and unlease IDs if user forcefully reloads page or closes tab

* Feature/fixvips (#205)

* updated vips doc create payload

* updated comments

* updated vips payload

* Feature/fixvips (#206)

* updated vips doc create payload

* updated comments

* updated vips payload

* updated vips payload

* updated vips payloadupdate vips payload

* updated vips payload

* updated vips payload

* BCDL 0 Padding (#202)

* fix bug

* Update forms, add back name of copy, move IDs around, fix bug

* update down_revision of migration yesterday

* offline mode changes (#209)

* Feature/fixicbcapi (#211)

* updated icbc payloads

* updated icbc payload

* updated icbc payloads

* fixed vi check digit

* updated icbc payloads

* fixed migrations

* docker file change (#210)

* new package lock (#212)

* updated dockerfile

* updated icbc payload

* fixed icbc payload

* offline mode (#213)

* fixed vehicle color

* updated docker

* updated env

* updated sw

* sw

* updated sw

* updated task sched

* fix icbc legacy city name mapping (#214)

* Pre launch bugs (#215)

* Make driver given name not required

* make nsc_prov_state default null, update validation rules for nsc_prov_state and nsc_no

* remove test

* update eCOS text

* make reasonable grounds require at least one option

* make date of impound not able to be a future date

* undo console log

* Fix date of impound not being a future date

* fix error related to dl scanner

* Fix/changetaskscheduler2 (#216)

* updated form handler to not log rabbit mq logs

* updated task scheduler log config

* pdated new task processing status for better tracking of backend poling tasks (#217)

* updated log text prefixes (#218)

* updated log text prefixes for all backend

* fixed rabbit mq connection

* fixed rabbitmq connection error

* updating rabbitmq error

* fixing rabbot error

* added toast messages for error handling, fixed IRP number issues (#219)

* sort dashboard rows by date

* add "return to dashboard" button to view past event

* fix extra text 12h ecos

* fix typo

* add date and time of release to 12h private tow

* remove "estimated time to complete"

* fix case where date released was 1969

* Assorted bug fixes (#221)

* small fix to make printing work properly again (#224)

* updated vips api mapping (#226)

* updated event field

* fixed gender field type

* updating agency field query

* updating to solve error with agency id in vips api

* fixed ilo mapping with cross ref (#230)

* trigger

* updated vips mapping

* add tooltip to motorcycle checkbox

* change coords of print layout

* admin dashboard fix (#225)

* updated logging for icbc and vips services

* add gender and date of expiry to dl scan

* sort vehicle years by descending

* remove quote

* add missing text

* update table

* updated jursdiction look up for vips api

* updated nsc prov mapping for vips

* indexeddb update (#234)

* updated vips mappings

* test

* trigger test

* fix incedent details not showing up after print preview is shown

* default VIPS RO DL number to blank

* trigger build

* update ILO table

* Add shorthand ILO names to front end form

* clear reasonable grounds other reason

* clear date/time of test

* clear hidden fields

* fix df-2911

* fix some cut off text in incident details

* add bootstrap table package, fix DF-2914

* fix print issues

* fix IDs not being unleased

* DF-2909: Set timeout to 60s

* add required asterisk

* fix hanging validation errors

* Fixes DF-2922

* Fixes: DF-2884

* fixes: DF-2918

* Fixes: DF-2884

* update vips integration

* (maybe) fixes: DF-2870

* fixes: DF-2912

* (maybe) fixes: DF-2908

* Various bug fixes and updated data migrations (#243)

* fixes: DF-2822

* Add sorting to date & surname

* DF-2840 & fix dl expiry date print

* fix misnomer

* Bump max word count for incident details to 3600

* Reduce incident details to 3000

* DF-2881

* DF-2848

* ignore legacy deps (#244)

* initial values missed (#245)

* changes to static jurisdiction checks (#246)

* removed outdated package, add custom sort function (#247)

* Quick fix (#248)

* spoiled and navigate away fixes, ICBC plate lookup fixes (#249)

* DF-2835

* issue with vips and icbc jurisdiction (#250)

* DF-2848

* remove None type values from VIPS payload

* DF-2735

* DF-2929

* DF-2940

* DF-2939

* bonus: fix scanner crash

* DF-2561

* clean up code

* missed province cd (#252)

* fix df-2935

* remove superfluous console logs

* needds to be null (#254)

* Missed ICBC province code (#255)

* icbc plate jurisdiction fix (#256)

* Dec 20 fixes (#257)

* ICBC plate lookup issues, Province print code fixes (#258)

* make model data (#259)

* remove vipsLicenceCreateObj

* move incident details to bottom of page

* swap dl number and jurisdiction fields

* Add redux to application, watch for updated SW and refresh

* Fix codes (#261)

* new logo (#262)

* remove ilo name print, add check for print_name

* text updates (df-2964)

* text update

* add field to drug details

* update validation

* add checkbox to print

* layout changes for vehicle province (#264)

* NSC ICBC issue (#265)

* df-2570

* do not show IRP fields

* update validation rules

* add logging

* update business logic

* fix critical error with ICBC

* updates to navigation and service worker registration

* don't send VI to VIPS

* bonus: fix 404?

* update flow to hyrbid VI

* update title at bottom of page for 12h/24h police copy

* update validation rule for vi + 24h reason for imp.

* fix text being cut off at top of landscape forms

* undo change

* DF-2969

* DF-2987

* DF-2988

* DF-2989

* DF-2990

* DF-2991

* DF-2992

* remove superfluous console logs

* fix nsc_prov_state set wrong sending to icbc

* DF-2969

* add PACIFIC TIME to eCOS

* try to fix 404

* DF-2994

* DF-2995

* update icbc button

* fix critical error printing forms

* add logging for ICBC DL lookiup

* fix extra incident details page

* update row sorting

* update variable name

* clear unlicensed fields

* fix IRP

* don't fetch IRP

* create failsafe messaging to user to print form when disconnected

* small fixes

* Never fetch existing form ID for user (#281)

* Na n error message (#282)

* df-2999

* add vehicle search sorting

* small bug fixes and missed location of vehicle for 12 hour (#284)

* modify existing modal with new flow and language (#285)

* updated send to vips email action (#286)

* remove hybrid flow code and several stale modals (#287)

* only fetch one of each ID

* Make NSC number field numeric only

* updated db migrate workflow to support future branches

* remove comment

* add missing validation rule (#291)

* search by registration number instead of plate number

* swap fields

* updated split image (#293)

* update moment validation

* icbc query fixes

* revert changes to registration number lookup

* Save in progress form (#297)

* Feature/pdfmultipages (#298)

* wip

* updated split page identification logic on backend

* fix barcode

* changes to fix issues with ilo print and save in progress (#300)

* add regex rule

* bug fixes (#302)

* validation issues (#303)

* updated version

---------

Co-authored-by: Sam Warren <[email protected]>
Co-authored-by: Amlan Chakladar <[email protected]>
Co-authored-by: Sam Warren <[email protected]>
Co-authored-by: David Kerins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-warren sam-warren sam-warren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JustinMacaulay @sam-warren