Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expiry Date Display Formatting #1948

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

cameron-eyds
Copy link
Collaborator

Issue #: /bcgov/entity#18443

Description of changes:

  • Updated expiry date display 'N/A' condition to include 9999 days

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@cameron-eyds cameron-eyds requested a review from doug-lovett June 24, 2024 16:18
@cameron-eyds cameron-eyds self-assigned this Jun 24, 2024
@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1948-1m0t6fvw.web.app

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another tough one.

@cameron-eyds
Copy link
Collaborator Author

Another tough one.

haha indeed!

@cameron-eyds cameron-eyds merged commit 3931cde into bcgov:main Jun 24, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants