Location Change component & Pad update #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-assets-dev--pr-1685-mxiu6she.web.app |
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-assets-dev--pr-1685-mxiu6she.web.app |
cameron-eyds
reviewed
Jan 9, 2024
cameron-eyds
reviewed
Jan 9, 2024
There was a problem hiding this comment.
As commented, i'm a little confused why the re-write backwards from using the script setup syntax.
It's the vue 3 approach and a benefit of the migration. It's a new way of doing things for sure, with it brings some learning of course but i'm curious why you chose to just rewrite the component using defineComponent?
cameron-eyds
reviewed
Jan 9, 2024
cameron-eyds
reviewed
Jan 9, 2024
cameron-eyds
reviewed
Jan 9, 2024
|
@cameron-eyds I refactored to use script setup |
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-assets-dev--pr-1685-mxiu6she.web.app |
cameron-eyds
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).