-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #1545 store audit records when grantingremoving delegated admin access #1625
feat: #1545 store audit records when grantingremoving delegated admin access #1625
Conversation
ianliuwk1019
commented
Oct 7, 2024
•
edited
Loading
edited
- move server/admin_management schema file into folder schemas and refactor some imports.
- add permission change audit relatled ORM mapping to model at server/admin_management.
- add permission_audit_history.py to hold permission aduit history related schema objects.
- add permission audit 'repository' and 'service' and the logic to store delegated admin permission change operation history.
- add tests
- adjust frontend permission history page to properly display role details for delegated admin based on mockup.
- The server/admin_management "schema" file is git moved to be under "schemas" folder. It is intended in the future to further refactor into groups of smaller schema files. Quite some files are only changed for the imports but the functionalities were not touched. These files can be ignored.
…emoving-delegated-admin-access
frontend/src/components/UserPermissionHistoryTable/PermissionDetailsCol.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work! Tested and demo-ed! Left one change request for maintainability
Quality Gate passed for 'nr-forests-access-management_admin'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!