Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #1545 store audit records when grantingremoving delegated admin access #1625

Conversation

ianliuwk1019
Copy link
Collaborator

@ianliuwk1019 ianliuwk1019 commented Oct 7, 2024

  • move server/admin_management schema file into folder schemas and refactor some imports.
  • add permission change audit relatled ORM mapping to model at server/admin_management.
  • add permission_audit_history.py to hold permission aduit history related schema objects.
  • add permission audit 'repository' and 'service' and the logic to store delegated admin permission change operation history.
  • add tests
  • adjust frontend permission history page to properly display role details for delegated admin based on mockup.

  • The server/admin_management "schema" file is git moved to be under "schemas" folder. It is intended in the future to further refactor into groups of smaller schema files. Quite some files are only changed for the imports but the functionalities were not touched. These files can be ignored.

@ianliuwk1019 ianliuwk1019 linked an issue Oct 7, 2024 that may be closed by this pull request
4 tasks
@ianliuwk1019 ianliuwk1019 marked this pull request as ready for review October 8, 2024 21:04
Copy link
Collaborator

@craigyu craigyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work! Tested and demo-ed! Left one change request for maintainability

Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Passed Quality Gate passed for 'nr-forests-access-management_admin'

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@craigyu craigyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@ianliuwk1019 ianliuwk1019 merged commit 465f066 into main Oct 11, 2024
12 of 13 checks passed
@ianliuwk1019 ianliuwk1019 deleted the feat/1545-store-audit-records-when-grantingremoving-delegated-admin-access branch October 11, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store audit records when granting/removing delegated admin access
2 participants