24849 change request search back to search functionality #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EPortman
requested review from
eve-git,
shaangill025,
stevenc987,
mengdong19,
ozamani9gh,
rarmitag and
flutistar
as code owners
EPortman
force-pushed
the
24849_change_request_search_back_to_search_functioality
branch
from
47bd3b9 to
0953943
Compare
|
rarmitag
approved these changes
Dec 11, 2024
EPortman
deleted the
24849_change_request_search_back_to_search_functioality
branch
EPortman
added a commit
that referenced
this pull request
Jan 21, 2025
* 24511 solr documentation (#1628) Signed-off-by: Shaanjot Gill <[email protected]> * 24849 search endpoint directly queries names db (#1629) * 24849 change request search back to being a search (#1630) * 24849 search works with name as well (#1631) * 24774 Bad Name Notifier (#1633) * create the job * create the job * revert invalid changes * update codkerfile * update according to sonarqube check * update * update dockerfile * update dockerfile * fix sonar errors * bug fix --------- Co-authored-by: eve-git <[email protected]> Co-authored-by: bolyachevets <[email protected]> * add logging (#1636) * 24774 Create bad-name-notifier workflow (#1637) * Create bad-name-notifier.yml * Rename bad-name-notifier.yml to bad-name-notifier-cd.yml * Create bad-name-notifier-CI.yml (#1638) * 24849 firm nrs added to names core only (#1632) * feat: firm nrs added to names core only * revert: changes to /search endpoint * 24225 update emails for new ia with magic link (#1634) (#1639) * 24225 update emails for new ia with magic link * fix lint issue * update env, template * fix bug * update the email and output templates * udpate comment * update small template * 24223 update get_instruction_group for CHG and CNV Co-authored-by: Kevin Zhang <[email protected]> * cd: update cd name (#1640) * Change cd name (#1641) * cd: update cd name * update clouddeploy name * cd: update clouddeploy (#1642) * fix service account names (#1643) * 24225 debug emaler (#1644) * 24225_update_magic_link_with_debug (#1645) * Update emailer-cd-gcp.yml * 24225_update_version_namex_api (#1646) * 24225_udpate_instruction_group_method (#1647) * 24225 update env variables (#1648) * 24225_update_debug_code (#1649) * 25012_update_email_outputs_debug (#1652) * create bad-designation-notifier (#1651) * create bad-designation-notifier * update config.py according to SonarQube duplication error * update config.py according to SonarQube duplication error * update according to SonarQube duplication error * update according to SonarQube duplication error * update according to sonarQube errors * 25012_emailer_api_debug (#1653) * Create sftp-nuans-report-ci.yml (#1616) * add a linefeed at the end of the files (#1655) * Create sftp-nuans-report-cd.yml (#1615) * update flask-jwt-oidc package (#1656) * Update flask jwt OIDC deps (#1657) * revert updates to api lock dependencies except jwt-oidc * remove broken flask-jwt-oidc package from lock file * emailer uses latest version of namex api (#1658) * 25167 add feature flags service enable won emails (#1659) * 25167 add_feature_flags_service_enable_won_emails * fix line issue * fix the env key * use the update namex api in emailer * Update Makefile - commented out update-env as per P.W. * Update Makefile - comment out update-env as per P.W. * Update Makefile - * Update Makefile - commented out update-env as per P.W. * Update Makefile - undo -> commented out update-env as per P.W. * Update Makefile - commented out update-env as per P.W. * Update Makefile - commented out update-env as per P.W. * Fix emailer issue (#1672) * fix: flags use env from config * chore: emailer uses latest version of namex * fix: allow users modify cancel from legacy side (#1673) * 25167 feature flgas enable won emails (#1674) * 25167_feature_flgas_enable_won_emails * use latest api with reference * 25256_update_email_content (#1675) * 25270_add_env_values (#1676) * Update emailer-cd-gcp.yml Removed API build when emailer changes. * 24739 Affiliating a new NR to specified account id (#1677) * affiliate new nr * update version * 25356 update_outputs_CHG_CNV_NR (#1679) * 25356_update_outputs_CHG_CNV_NR * update emailer poetry to use the latest api * feat: use db in gcp * chore: update version of namex used * fix: permission issue * feat: nr-day-job uses gcp db * feat: namex pay uses gcp db * feat: use namex db in gcp * chore: remove auto-analyze service --------- Signed-off-by: Shaanjot Gill <[email protected]> Co-authored-by: Shaanjot Gill <[email protected]> Co-authored-by: eve-git <[email protected]> Co-authored-by: eve-git <[email protected]> Co-authored-by: bolyachevets <[email protected]> Co-authored-by: Omid Zamani <[email protected]> Co-authored-by: Kevin Zhang <[email protected]> Co-authored-by: rarmitag <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
https://app.zenhub.com/workspaces/names-team-board-new-655554cbddd49510027dad2e/issues/gh/bcgov/entity/24849
Description of changes:
In my previous PR, #1629, I mistakenly took away the functionality of being able to search and limit the number of requests returned - effectively changing the search into an exact match.
This PR reverts that mistake allowing it to function as a search once again.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).