Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6177] Project Summary View Bugs #3287

Merged
merged 8 commits into from
Oct 29, 2024

Conversation

taraepp
Copy link
Collaborator

@taraepp taraepp commented Oct 29, 2024

Objective

  • take all the "edit" features out of the view mode for the form
  • throw in const { isEditMode } = useContext(FormContext); everywhere
  • create the view mode for input elements that were missing it (checkboxes, radio)
  • default to showing "N/A" for empty text/text-like fields in view mode
  • style everything!
  • technically ticket was only for CORE, but I copied over the new styles to MS too. The project summary form is never in view mode, but I did a little check by forcing it in the code and it looks nice. 🤷‍♀️ (it looks the same as it does on CORE)
  • according to the snap updates it affected reports! Gave it a look and it seems a-ok (will note in ticket for QA)

MDS-6177

Why are you making this change? Provide a short explanation and/or screenshots

Copy link

sonarcloud bot commented Oct 29, 2024

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
62.1% Coverage on New Code (required ≥ 80%)
6.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 29, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 29, 2024

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@taraepp taraepp merged commit d1dd9bd into develop Oct 29, 2024
13 of 15 checks passed
@taraepp taraepp deleted the mds-6177-project-summary-view-bugs branch October 29, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants