Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6139] - Disable tabs/buttons in project overview #3281

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

taraepp
Copy link
Collaborator

@taraepp taraepp commented Oct 24, 2024

Objective

  • now that the button does something, limit when the button can be clicked
  • the disabled styling of the tabs on MS had been overridden by a more specific rule so changed some of that styling to make it appear disabled
  • it didn't like a duplicate selector for ant-modal-footer in that file so I deduplicated it by merging the padding styling into the other rule.

MDS-6139

Why are you making this change? Provide a short explanation and/or screenshots

Copy link

sonarcloud bot commented Oct 24, 2024

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_minespace-web'

Failed conditions
51.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 24, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@taraepp taraepp merged commit 584b751 into develop Oct 24, 2024
12 of 13 checks passed
@taraepp taraepp deleted the mds-6139-disabling branch October 24, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants