[CHORE] - Finalize Credential ID for UNTP DCC MAP #3280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on UNTPDCC and BCMinesActPermitCredential versions
update context reference to 0.5.0
stop using sovrin did, just use did:web from tdw server.
remove hardcode from id path
name is included, issuanceDate is now validFrom.
DI proofs are going to be required by orgbook, but maybe not others. removed other WIP code with different endpoints
Jsyro
added
👍 Ready for review
matbusby-fw
previously approved these changes
Oct 24, 2024
|
matbusby-fw
approved these changes
Oct 25, 2024
simensma-fresh
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW ENV VAR:
ORGBOOK_CREDENTIAL_BASE_URL=https://dev.orgbook.traceability.site/credentialsResult:
The generated credentials can manually publish these to orgbook for testing, but will build automatic publishing later.
Future consideration.
BitStringStatusListis also something we may want to let the orgbook publisher manage, otherwise MDS will need to host it. Another future decision.