Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6139] project stages application button #3273

Merged
merged 8 commits into from
Oct 22, 2024

Conversation

taraepp
Copy link
Collaborator

@taraepp taraepp commented Oct 21, 2024

Objective

  • make the application "start" button work on MS
  • also fixed some "duplicate key" warnings and made things TS-y
  • I didn't see the same issue on CORE but made that TS-y too.
  • fixed the route for the app-help work on those pages too

MDS-6139

Why are you making this change? Provide a short explanation and/or screenshots

@taraepp taraepp force-pushed the mds-6139-project-stages-application-button branch from 1d237f6 to b3bbecb Compare October 21, 2024 18:08
@taraepp taraepp changed the title MDS-6139 project stages application button [MDS-6139] project stages application button Oct 21, 2024
matbusby-fw
matbusby-fw previously approved these changes Oct 21, 2024
Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. Sonarcloud is pointing out a valid issue that I know didn't have anything to do with your code, but should be a pretty easy fix:

label =
            record.key && record.stage_status
              ? `[${record.stage_status_hash[text]}]` || "N/A"
              : "[Not submitted]";

Since it's interpolating the string and using [] it is always going to be truthy. Might be worth fixing this here?

matbusby-fw
matbusby-fw previously approved these changes Oct 21, 2024
Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦙

Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_minespace-web'

Failed conditions
33.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 21, 2024

Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐫

@henry-ngo
Copy link

maybe wrong tag for me? :)

@taraepp taraepp requested review from henryoforeh-dev and matbusby-fw and removed request for henry-ngo October 21, 2024 20:25
@taraepp taraepp merged commit 8952af4 into develop Oct 22, 2024
14 of 15 checks passed
@taraepp taraepp deleted the mds-6139-project-stages-application-button branch October 22, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants