-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDS-6139] project stages application button #3273
Conversation
1d237f6
to
b3bbecb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me. Sonarcloud is pointing out a valid issue that I know didn't have anything to do with your code, but should be a pretty easy fix:
label =
record.key && record.stage_status
? `[${record.stage_status_hash[text]}]` || "N/A"
: "[Not submitted]";
Since it's interpolating the string and using []
it is always going to be truthy. Might be worth fixing this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦙
Quality Gate failed for 'bcgov-sonarcloud_mds_minespace-web'Failed conditions |
Quality Gate passed for 'bcgov-sonarcloud_mds_common'Issues Measures |
Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐫
maybe wrong tag for me? :) |
Objective
MDS-6139
Why are you making this change? Provide a short explanation and/or screenshots