Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24715 Updates to support legacy ledger display name #3169

Merged
merged 5 commits into from
Jan 13, 2025

Conversation

chenhongjing
Copy link
Collaborator

@chenhongjing chenhongjing commented Jan 9, 2025

Issue #: /bcgov/entity#24715

Description of changes:

  • Add legacy ledger display name mapping
  • Populate colinDisplayName in filing.meta_data
  • Update legal-api to return legacy display name
  • misc updates(TODOs & notes)

Pending Issue
- Suffix of CoD

Testing
BC0623689
Local (new)
image

Dev (old)
image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@chenhongjing chenhongjing self-assigned this Jan 9, 2025
Signed-off-by: Hongjing Chen <[email protected]>
@chenhongjing chenhongjing marked this pull request as ready for review January 9, 2025 17:27
@chenhongjing chenhongjing requested a review from argush3 January 9, 2025 17:27
Copy link
Collaborator

@argush3 argush3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

just the one comment.

I think you mentioned this already but just wanted to confirm. No changes required for the FE right?

@chenhongjing
Copy link
Collaborator Author

looks good.

just the one comment.

I think you mentioned this already but just wanted to confirm. No changes required for the FE right?

Yes, not required for FE.

@chenhongjing chenhongjing merged commit 4323077 into bcgov:main Jan 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants