Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18240 - Fixed Expiring Soon Emails #2328

Merged

Conversation

JazzarKarim
Copy link
Collaborator

Issue #: /bcgov/entity#18240

Description of changes:

  • Moving the Names team commit to the release branch that Sev created

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@JazzarKarim JazzarKarim self-assigned this Nov 24, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@JazzarKarim
Copy link
Collaborator Author

JazzarKarim commented Nov 24, 2023

Sev, don't worry about the lint issues. I discovered them in my emailer PR and fixed them there: #2327

They carried over from previous PRs. I'm assuming from names team work.

@severinbeauvais
Copy link
Collaborator

@argush3 This is the same as #2324 but against the release branch, so that it can be pushed to Dev and then Test asap. Riyaz is OK with it.

(Names team committed this after our release cutoff, but they need it in Prod before Tuesday.)

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks the same as the original PR.

@severinbeauvais severinbeauvais merged commit 61dc58b into bcgov:release-2.95.0 Nov 24, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants