18053 Legal API - Validation (AGM Extension) #2298
Conversation
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2298 +/- ##
==========================================
- Coverage 77.37% 77.03% -0.34%
==========================================
Files 202 205 +3
Lines 11602 11931 +329
Branches 1961 2013 +52
==========================================
+ Hits 8977 9191 +214
- Misses 2043 2143 +100
- Partials 582 597 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
| from unittest.mock import patch | ||
|
|
||
| import pytest | ||
| from registry_schemas.example_data import AGM_EXTENSION, FILING_HEADER |
There was a problem hiding this comment.
If AGM_EXTENSION isn't used you can probably remove it, otherwise looks good!
legal-api/src/legal_api/services/filings/validations/agm_extension.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
| if intended_agm_date > curr_ext_expire_date: | ||
| msg.append({'error': 'Intended AGM date should not be greater than current extension expiry date.', | ||
| 'path': f'{AGM_EXTENSION_PATH}/intendedAgmDate'}) |
There was a problem hiding this comment.
so when i said intended_agm_date should not be greater than the extension expiry date, I probably wasn't clear enough. I meant the intended_agm_date should not be greater than whatever new expiry date you would be granting for the extension being requested.
There was a problem hiding this comment.
intended_agm_date validation can be removed as per Mihai's comment in the ticket.
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
|
SonarCloud Quality Gate failed.
|
Issue #: /bcgov/entity#18053
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).