-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
18370 Fix list of outputs AGM extension #2291
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2291 +/- ##
==========================================
- Coverage 77.37% 76.74% -0.64%
==========================================
Files 202 204 +2
Lines 11602 11836 +234
Branches 1961 1993 +32
==========================================
+ Hits 8977 9083 +106
- Misses 2043 2160 +117
- Partials 582 593 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks for adding the tests!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😺
Issue #: /bcgov/entity#18370
Description of changes:
NOTE: implementation and logic of the letter to be implemented by the agm extension outputs ticket bcgov/entity#17931
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).