Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18286 - Add in BECV - NR for Benefit to Limited Name Change is not working #2259

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Oct 24, 2023

Add in BECV, I believe this was new by Eve to fix the data for an alteration NR.

image

bcgov/entity#18286

@seeker25 seeker25 self-assigned this Oct 24, 2023
@seeker25 seeker25 changed the title Update alteration.py 18286 - Add in BECV - NR for Benefit to Limited Name Change is not working Oct 24, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seeker25 seeker25 temporarily deployed to dev October 24, 2023 18:16 — with GitHub Actions Inactive
@seeker25 seeker25 requested a review from argush3 October 24, 2023 18:16
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #2259 (0d31ebe) into main (fec0862) will decrease coverage by 0.18%.
Report is 7 commits behind head on main.
The diff coverage is 38.29%.

@@            Coverage Diff             @@
##             main    #2259      +/-   ##
==========================================
- Coverage   77.03%   76.86%   -0.18%     
==========================================
  Files         161      161              
  Lines        9838     9875      +37     
  Branches     1660     1667       +7     
==========================================
+ Hits         7579     7590      +11     
- Misses       1801     1827      +26     
  Partials      458      458              
Flag Coverage Δ
legalapi 76.86% <38.29%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
legal-api/src/legal_api/core/meta/filing.py 91.11% <100.00%> (+0.55%) ⬆️
legal-api/src/legal_api/models/filing.py 92.41% <ø> (ø)
...al_api/resources/v2/business/business_directors.py 97.36% <ø> (-0.14%) ⬇️
...gal_api/services/filings/validations/alteration.py 83.01% <100.00%> (ø)
legal-api/src/legal_api/version.py 100.00% <100.00%> (ø)
legal-api/src/legal_api/reports/report.py 26.35% <11.11%> (-0.09%) ⬇️
...egal-api/src/legal_api/resources/v2/namerequest.py 28.57% <19.23%> (-18.49%) ⬇️

@seeker25 seeker25 merged commit 4a3a326 into main Oct 24, 2023
10 of 11 checks passed
@seeker25 seeker25 deleted the fix_for_alteration_nr branch January 25, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants