15589 - Backend changes for SR memorandum update. #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeker25
commented
Apr 11, 2023
| 'legalFilings': [ | ||
| {'specialResolution': f'{base_url}/api/v2/businesses/CP7654321/filings/1/documents/specialResolution'}, | ||
| ] | ||
| ], | ||
| 'receipt': f'{base_url}/api/v2/businesses/CP7654321/filings/1/documents/receipt', |
There was a problem hiding this comment.
Tried to put it alphabetical here.
seeker25
commented
Apr 11, 2023
| 'legalFilings': [ | ||
| {'specialResolution': f'{base_url}/api/v2/businesses/CP7654321/filings/1/documents/specialResolution'}, | ||
| ] | ||
| ], | ||
| 'receipt': f'{base_url}/api/v2/businesses/CP7654321/filings/1/documents/receipt' |
There was a problem hiding this comment.
Tried to put it alphabetical here.
seeker25
commented
Apr 11, 2023
| } | ||
| }, | ||
| HTTPStatus.OK, '2017-10-01' | ||
| ), | ||
| ('specres_court_completed', 'CP7654321', Business.LegalTypes.COOP.value, | ||
| 'specialResolution', SPECIAL_RESOLUTION, 'courtOrder', COURT_ORDER, Filing.Status.COMPLETED, | ||
| {'documents': {'receipt': f'{base_url}/api/v2/businesses/CP7654321/filings/1/documents/receipt', | ||
| {'documents': { | ||
| 'certificate': f'{base_url}/api/v2/businesses/CP7654321/filings/1/documents/certificate', |
There was a problem hiding this comment.
Tried to put it alphabetical here.
Codecov Report
@@ Coverage Diff @@
## main #1994 +/- ##
==========================================
+ Coverage 77.13% 77.19% +0.06%
==========================================
Files 189 156 -33
Lines 10370 9315 -1055
Branches 1721 1551 -170
==========================================
- Hits 7999 7191 -808
+ Misses 1841 1685 -156
+ Partials 530 439 -91
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This reverts commit 470e161.
|
SonarCloud Quality Gate failed.
|
argush3
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#15589
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).