Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create UI: issues found by UX Assurance #19754

Closed
2 tasks
severinbeauvais opened this issue Feb 7, 2024 · 5 comments
Closed
2 tasks

Create UI: issues found by UX Assurance #19754

severinbeauvais opened this issue Feb 7, 2024 · 5 comments
Assignees
Labels
bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. good first issue Good for newcomers Priority3 UX Assurance

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Feb 7, 2024

These were found while ux-assuring #19041.

Issue 1

  • (edited) Remove the first bullet as it is redundant to the checkbox statement. A future ticket will update the shared Certify component and update all UIs that use it. Here is what we want it to look like right now:
  • Association renamed as Businesses.

image.png

Issue 2 likely duplicate of #19058

Observation:

  • A business that was admin dissolved and put back on doesn't seem to get fetched by the business look-up. BCREG2014 has a draft regular amalgamation and if you try to add BC0871583, it won't show up in the look-up even though it is active and affiliated.

There's an error in affiliation related code that's preventing look-up. This is an error in console when trying to create a numbered amalgamation from Name Request.

image.png

@severinbeauvais severinbeauvais added bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. labels Feb 7, 2024
@severinbeauvais
Copy link
Collaborator Author

@yuisotozaki Is the second issue the same as #19058? If you're unsure, can you provide steps to reproduce? (and what do you mean by "preventing look-up"?)

@yuisotozaki
Copy link

@severinbeauvais I think it's the same thing. It's intermittent. If I continue to try to start an amalgamation from Name Request, sometimes, I get this error, and sometimes, it's fine.

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Feb 8, 2024

@yuisotozaki Can you please paste the design (or link to it) for how you want the updated Certify component to look? Thx.

Ahh, never mind! In this ticket we'll make it look like the screenshot above. A future ticket will make the change to the shared Certify component and update all UIs that use it.

@severinbeauvais
Copy link
Collaborator Author

Both changes in issue 1 have been implemented (for regular and short-form amalgamations of all entity types).

@yuisotozaki
Copy link

Ready for QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. good first issue Good for newcomers Priority3 UX Assurance
Projects
None yet
Development

No branches or pull requests

4 participants