Create UI: final checks and validations + save/resume, etc - DO THIS LAST

[severinbeauvais]

This is similar to #18689.

• page validations
  • make sure Resulting Business Name component is valid
• filing validation
• verify fee codes (may be different from regular amalgamations)
  • make sure correct fee codes are being used for vert/horiz
  • make sure correct fee code is used if entity type changes
• save and resume draft -- do existing functions handle it already?
• verify regular user vs staff user (ie, conditional components, filing it)
• update step 5's Certify block with bullet points and typo fixes (UXPin design)
• move common certify statements/clauses to a file of constants
• add/update unit tests specific to short-form amalgamations will be done in Create UI: unit tests for everything not yet done #19044
• add validation for a TING that is part of a FE filing (ie, has Future Effective Amalgamation alert)
• add Account-Id header to auth info call and check response for authorization (affiliation) will be done in Create UI - cannot use TING affiliated to login but not account #19698

[severinbeauvais]

This is a good choice as an extra ticket in Sprint 20.2 but I've left it in the Product Backlog in case we don't get around to it.

[severinbeauvais]

@yuisotozaki The functional work in this ticket is complete (and merged into Dev), if you want to start assuring this early. I am still working on the unit tests but they will have no functional impact.

[yuisotozaki]

Observation and a last minute update.
The certify block across the filings will be updated to state "I, {my name}, confirm the following:" followed by bullet points. I'd like to make that change in Amalgamation now.

[severinbeauvais]

Observation and a last minute update. The certify block across the filings will be updated to state "I, {my name}, confirm the following:" followed by bullet points. I'd like to make that change in Amalgamation now.

That's a change to the shared Certify component, which would exceed this ticket's scope and estimate. New ticket, please and thanks.

[severinbeauvais]

Test Notes

See todo list above for what was done in this ticket.

In particular, please check all page and filing validations, and check the new TING validation (FE amalg). Thank you.

[yuisotozaki]

Certify block design revert so that we can handle the update in the sweeper ticket later. We'll remove the first bullet as it is redundant to the checkbox statement.

[yuisotozaki]

deleted duplicate comment

[yuisotozaki]

Observation:

• A business that was admin dissolved and put back on doesn't seem to get fetched by the business look-up. BCREG2014 has a draft regular amalgamation and if you try to add BC0871583, it won't show up in the look-up even though it is active and affiliated.

There's an error in affiliation related code that's preventing look-up. This is an error in console when trying to create a numbered amalgamation from Name Request.

[severinbeauvais]

Yui - I have copied the issue you found to #19754. Can we move THIS ticket to RFQA?

[yuisotozaki]

Ready for QA.