-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create UI: implement "Existing Business Information" component (step 1) - PART 1 #19264
Comments
See #15314 description for possibly useful information. |
Test NotesAs part of this ticket, I replace duplicated code with a new MessageBox component. This affects the following:
|
@yuisotozaki Ready for your assurance, please and thanks. You can create your own (named) continuation in draft, or try this one: https://dev.create.business.bcregistry.gov.bc.ca/continuation-in-business-home?id=TmCY3xvKFc
If you see any needed changes, add a comment in this ticket, but I will fix them in #20889. |
Observations - mostly errors in the design:
|
I think that makes sense. I'll ponder upon this further as we work towards step 5. I'd like to see the whole step 1 completed and see how it flows in these error cases. |
I referenced your comments 1 through 3 in #20889. Can THIS ticket be moved to RFQA now? |
Yes - Ready for QA. |
We showed in Sprint Demo. |
add unit tests for new codewill be done in Create UI: implement "Existing Business Information" component (step 1) - PART 2 #20889Note: business lookup will search for both active and historical A companies.
See #19462, #15315 and #15524 descriptions for additional details, but Figma is source of truth.
The text was updated successfully, but these errors were encountered: