Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create UI: implement framework (DO THIS FIRST IN CREATE UI) #18536

Closed
8 of 13 tasks
severinbeauvais opened this issue Nov 10, 2023 · 4 comments
Closed
8 of 13 tasks

Create UI: implement framework (DO THIS FIRST IN CREATE UI) #18536

severinbeauvais opened this issue Nov 10, 2023 · 4 comments
Assignees
Labels
ENTITY Business Team

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Nov 10, 2023

To do

  • add views (regular only atm)
    • prep initial components
  • add routes and route names
  • add stepper
  • add initial resources
    • fee codes
    • different text depending on entity type / amalgamation type?
    • different rules depending on entity type / amalgamation type?
    • anything else that can be moved into resources instead of hard-coded
  • update bcrs-shared-components enums
    • filing codes
    • filing names
    • filing types
    • amalgamation types
  • add misc getters ("is amalgamation application", "is valid", etc)
  • add initial validations
  • update app loading and save actions (similar to IA)
  • add initial unit tests moved to Create UI: more framework changes, validation, etc (DO THIS LAST IN CREATE UI) #18689

To look into later

@severinbeauvais severinbeauvais added the ENTITY Business Team label Nov 10, 2023
@severinbeauvais severinbeauvais changed the title Create UI: implement new Amalgamating Businesses component Create UI: implement framework (DO THIS FIRST IN CREATE UI) Nov 11, 2023
@severinbeauvais
Copy link
Collaborator Author

@Mihai-QuickSilverDev Could you please provide the filing codes for an amalgamation? Are there different codes for regular vs short? Are there different code for different entity types (BC/BEN/CC/ULC)?

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Nov 20, 2023

@riyazuddinsyed This ticket has changes in Release 19.5a, and will have changes in a further release. This is why it is tagged to this release but is in progress still.

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Nov 21, 2023

Test Notes

If there is not yet the ability to create a draft amalgamation application and navigate to it (similar to IA), then you can:

  1. create a new IA (named or numbered)
  2. go into Legal db (Postgres) and change the IA filing to an amalgamation filing
  3. load Create UI with an amalgamation route and the ID of the temp business number; for example only (replace Txxx as needed):
    https://dev.create.business.bcregistry.gov.bc.ca/amalg-reg-information?id=T7HKt2pK2z&accountid=2288

@yuisotozaki
Copy link

Ready for QA.

This was referenced Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENTITY Business Team
Projects
None yet
Development

No branches or pull requests

3 participants