Middle Name of Directors not showing up in Directors correction for BEN's Alterations.

[riyazuddinsyed]

Describe the bug in the current situation
When staff members are making corrections to a Director Change filing, they may notice that if the director has a middle name, it doesn't appear during the correction process.

Steps to Reproduce
Steps to reproduce the behavior:

1. Go to 'https://test.edit.business.bcregistry.gov.bc.ca/BC1061691/correction/?correction-id=392878&accountid=1999'
2. Notice that under the Directors section, the Middle Name doesn't show up

[Mihai-QuickSilverDev]

This error is already in Production. Tested it on BC1444534. We did not receive complaints yet, however, it should be fixed. Priority between a 2 and a 3.

[jdyck-fw]

Middle Name and Middle Initial label mismatch is likely at play here.

[jdyck-fw]

@Mihai-QuickSilverDev will review for an epic to include this one into.

[jdyck-fw]

@Mihai-QuickSilverDev - Epic for this one please.

[Mihai-QuickSilverDev]

Done.

[severinbeauvais]

Test Notes

It turns out that this error occurred in all filings, not just corp (BEN) corrections or alterations as reported above.

This error was already fixed for (firm) change and (firm) conversion filings. Instead of replicating the fix in 9 different filings, I moved the fix to the LegalServices class (which is where the directors/parties are fetched).

Therefore, this fix affects all the following filings. (I tested most of them locally already; see PR for screenshots).

1. Alteration
2. LimitedRestorationExtension
3. LimitedRestorationToFull
4. SpecialResolution
5. Change
6. Conversion
7. CoopCorrection
8. CorpCorrection
9. FirmCorrection

[severinbeauvais]

Sample Businesses in Dev

https://dev.business.bcregistry.gov.bc.ca/BC0871417 (for alteration and corp correction)

https://dev.business.bcregistry.gov.bc.ca/FM1052869 (for change and conversion)

https://dev.business.bcregistry.gov.bc.ca/CP1002588 (for special resolution and coop correction)

https://dev.business.bcregistry.gov.bc.ca/FM1053038 (for firm correction)

[severinbeauvais]

The fix is merged into Dev and I have verified it there. Ready for QA!