-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: 1692 tooltips #1774
Feat: 1692 tooltips #1774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great 🤩 I'm just not sure about creating snapshots from form pages; we need to change them every time we change a single line in those form pages. what do you think?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the idea of keeping all tooltip text in one place.
I'm not attached to the snapshot tests. I added them based on your comment in the old PR, |
My main concern was inadvertently changing certain texts, but a single unit test would ensure that they are not altered by mistake. However, the new approach of keeping them in a separate file minimizes the risk of accidental changes. We are now good to proceed. |
d7301a7
to
3429aca
Compare
73e887b
to
20ce757
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great 😃
card #1692
continued from https://github.com/bcgov/cas-cif/pull/1771/files