Edit state of SI entry #95
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
=======================================
Coverage ? 79.19%
=======================================
Files ? 28
Lines ? 1668
Branches ? 93
=======================================
Hits ? 1321
Misses ? 258
Partials ? 89
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-btr-dev--pr-95-sq27aeed.web.app |
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-btr-dev--pr-95-sq27aeed.web.app |
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-btr-dev--pr-95-sq27aeed.web.app |
| @@ -142,7 +142,7 @@ | |||
| id="addNewPersonBirthdate" | |||
| class="mt-3" | |||
| :max-date="new Date()" | |||
| :placeholder="$t('placeholders.dateSelect.birthdate')" | |||
| :placeholder="significantIndividual.profile.birthDate || $t('placeholders.dateSelect.birthdate')" | |||
There was a problem hiding this comment.
this should set the initialDate prop with the existing birthdate value instead of the placeholder
| const emits = defineEmits<{ | ||
| add: [value: SignificantIndividualI], | ||
| cancel: [value: any], | ||
| update: [value: any], |
There was a problem hiding this comment.
I think you can add typing to this
| } | ||
|
|
||
| cy.get('[data-cy="individualsSummaryTable"]').get('td') | ||
| .should('contain.text', 'No significant individuals added yet') |
There was a problem hiding this comment.
this will only be true if the business had 2 existing individuals (which is why it fails in the CI). This should dynamically calculate how many existing individuals are there and verify there is at least 1.
the tests above and below fail for a similar reasons (starting existing individuals are different than the test expects)
FUTURE: we should have a specific test business for these tests that doesn't get interfered with
| } | ||
|
|
||
| cy.get('[data-cy="individualsSummaryTable"]').get('td') | ||
| .should('contain.text', 'No significant individuals added yet') |
| @@ -22,10 +22,10 @@ | |||
|
|
|||
| <script setup lang="ts"> | |||
| const emit = defineEmits<{(e: 'update:modelValue', value: string | undefined): void }>() | |||
| defineProps({ | |||
| modelValue: { type: String, default: undefined }, | |||
| const props = defineProps({ | |||
There was a problem hiding this comment.
can the emit above still be undefined ?
*Issue:*bcgov/entity#18726
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).