birthdate format fix / preferred field typo fix #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kial Jinnah <[email protected]>
Signed-off-by: Kial Jinnah <[email protected]>
Signed-off-by: Kial Jinnah <[email protected]>
… its own step Signed-off-by: Kial Jinnah <[email protected]>
Signed-off-by: Kial Jinnah <[email protected]>
hfekete
approved these changes
Dec 18, 2023
| @@ -213,23 +213,23 @@ | |||
| }, | |||
| { | |||
| "key": "Date", | |||
| "value": "Wed, 13 Dec 2023 21:40:11 GMT" | |||
| "value": "Fri, 15 Dec 2023 18:21:32 GMT" | |||
There was a problem hiding this comment.
Shouldnt we b e using dates in ISO format ?
There was a problem hiding this comment.
yep you're right -- think I just need to run the example again
There was a problem hiding this comment.
oh wait nvm this is just in the header value (automatic from postman)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue:*bcgov/entity#18676
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).