changes to redaction #213
changes to redaction #213
Conversation
|
/gcbrun |
| @@ -104,6 +106,19 @@ def redact_field(field, redact_type): | |||
| rv += ' ' | |||
| rv += word[0:1] + '***' | |||
| redacted_field = rv | |||
| elif redact_type == RedactionType.REDACT_MONONYM_LN: | |||
| rv = '' | |||
There was a problem hiding this comment.
I tested this function locally, and for Little Red Riding Hood I get: Little Red R*** H***
is that what we want ?
if we want to redact every word you can use following:
temp = []
words = field.split()
for word in words:
temp.append(word[0:1] + '***')
rv = ' '.join(temp)
return rv
There was a problem hiding this comment.
We aren't using REDACT_MONONYM_LN I was working on it and realized this case and when I dug into it we aren't using the modifiers as we have to show the full name. The other use potential problem with the function is when for instance someone is 'Jr.' or 'the III' because these go after the last name
There was a problem hiding this comment.
With the above stated I have updated the function to properly only redact the last word so Little Red Riding Hood becomes Little Red Riding H*** and Queen Elizabeth II becomes Queen Elizabeth I***
*Issue:*bcgov/entity#23402
Description of changes:
Redaction is now the same (currently) across Staff and Public. The rules have also changed to match the spreadsheet in the ticket.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).