allow information to be unspecified if reason is provided and box is … #192
Conversation
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-btr-dev--pr-192-17a547yp.web.app |
| @@ -9,13 +9,18 @@ | |||
| {{ item.email }} | |||
| </div> | |||
| </div> | |||
| <div v-if="item.address" class="flex"> | |||
| <div | |||
There was a problem hiding this comment.
Are you sure we dont want to display other parts of the address if there is no country in the address ?
There was a problem hiding this comment.
yeah the BcrosAddressDisplay will handle an empty country so I think this should be reverted?
There was a problem hiding this comment.
The problem here is the icon will show if there is no information because address will be a populated object with keys like city: '' and then the icon shows with nothing and I didn't want to add all of the parts to the v-if.
Therefore I've added a computed value with all of the bits and am using that instead
| const { ownershipOrControlStatements, personStatements } = getPersonAndOwnershipAndControlStatements(sif) | ||
|
|
||
| for (const personS of personStatements) { |
There was a problem hiding this comment.
Is this fix for some UI situation ?
Why are we deleting keys from objects that are empty ?
There was a problem hiding this comment.
This is for the api actually, because if the UI passes along '' many of the keys fail
There was a problem hiding this comment.
I think it would be good to add a comment here
There was a problem hiding this comment.
Comment added
| @@ -224,7 +224,8 @@ export const getSIsFromBtrBodsSubmission = (submission: BtrFilingI): SiSchemaTyp | |||
| const oocs = _findOwnershipOrControlStatement(submission, person.statementID) | |||
| if (person && oocs) { | |||
| const si = _getSi(person, oocs, businessIdentifier) | |||
| if (si.effectiveDates.filter(date => !date.endDate).length === 0) { | |||
| const fullInfo = !(si.couldNotProvideMissingInfo && si.missingInfoReason) | |||
There was a problem hiding this comment.
for full info you can check !si.couldNotProvideMissingInfo if that one is provided, the other one is mandatory.
…ticked
*Issue:*bcgov/entity#22911
Description of changes:
Api schema change to accept either what it currently does or a name and a reason for not providing the rest. UI changes to support less information being available
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).