Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19207 pay service integration #105

Merged
merged 6 commits into from
Jan 29, 2024

Conversation

kialj876
Copy link
Collaborator

*Issue:*bcgov/entity#19207

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

Signed-off-by: Kial Jinnah <[email protected]>
Signed-off-by: Kial Jinnah <[email protected]>
Signed-off-by: Kial Jinnah <[email protected]>
@kialj876 kialj876 self-assigned this Jan 26, 2024
@kialj876 kialj876 requested a review from hfekete January 26, 2024 20:22
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@f950504). Click here to learn what that means.

❗ Current head 931f3fb differs from pull request most recent head e992c93. Consider uploading reports for the commit e992c93 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage        ?   84.51%           
=======================================
  Files           ?       27           
  Lines           ?      736           
  Branches        ?        0           
=======================================
  Hits            ?      622           
  Misses          ?      114           
  Partials        ?        0           
Flag Coverage Δ
btr-api 84.51% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

btr-api/src/btr_api/config.py Show resolved Hide resolved
btr-api/src/btr_api/logging.py Outdated Show resolved Hide resolved
btr-api/src/btr_api/resources/submission.py Show resolved Hide resolved
@hfekete
Copy link
Collaborator

hfekete commented Jan 29, 2024

Looks good!
Can you add tickets for todos if we dont have them already, thanks !

Signed-off-by: Kial Jinnah <[email protected]>
@kialj876 kialj876 merged commit e393407 into bcgov:main Jan 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants