-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
18162 AGM Location Change - part 2 #146
Conversation
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
location as a string doesn't support the requirements easily.
please explain how that will do that
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
}, | ||
"agmLocation": { | ||
"type": "string", | ||
"maxLength": 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if someone does type in address, this is too short to hold the data we have for addresses. and that's assuming they use the codes for state/prov & country and don't spell them out.
* 18162 AGM Location Change II Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca> * fix Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca> * update max len of AGM location Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca> * fix test Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca> --------- Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Issue #: /bcgov/entity#18162
Description of changes:
reason
fieldagmLocation
fieldBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-schemas license (Apache 2.0).