Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24423 Added conditional dashboard redirect #703

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

severinbeauvais
Copy link
Collaborator

Issue #: bcgov/entity#24423

Description of changes:

  • app version = 7.4.5
  • on start, redirect to new dashboard if FF is True

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

- on start, redirect to new dashboard if FF is True
navigate(dashboardUrl)
return
}

Copy link
Collaborator Author

@severinbeauvais severinbeauvais Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had hoped to add this code to main.ts -- before Vue was started -- but for FF targeting, the LD user first had to be updated (line 443, above).

This code redirects to the new business dashboard if the FF is True. This means we don't have to update Namerequest UI or Auth Web (My Business Registry) or anywhere else to redirect conditionally.

Note that $route.fullPath includes any URL parameters (such as Filing ID and Account).

If you want to test this, contact me with your IDIR and I'll update LaunchDarkly to target you only.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sample redirect URL when :

image

@severinbeauvais
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

bcregistry-sre commented Nov 14, 2024

Temporary Url for review: https://business-filings-dev--pr-703-athj4a1p.web.app

SB says, try this: https://business-filings-dev--pr-703-athj4a1p.web.app/BC0870895?param1=severin&param2=123

It should redirect only if the FF is True for you.

Copy link
Collaborator

@hfekete hfekete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks for this quick PR !!

Copy link
Collaborator

@JazzarKarim JazzarKarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@severinbeauvais severinbeauvais merged commit dd86d46 into bcgov:main Nov 14, 2024
10 of 11 checks passed
@ketaki-deodhar
Copy link
Collaborator

got to this a bit late but looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants