-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
24423 Added conditional dashboard redirect #703
Conversation
- on start, redirect to new dashboard if FF is True
Quality Gate passedIssues Measures |
navigate(dashboardUrl) | ||
return | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had hoped to add this code to main.ts -- before Vue was started -- but for FF targeting, the LD user first had to be updated (line 443, above).
This code redirects to the new business dashboard if the FF is True. This means we don't have to update Namerequest UI or Auth Web (My Business Registry) or anywhere else to redirect conditionally.
Note that $route.fullPath
includes any URL parameters (such as Filing ID and Account).
If you want to test this, contact me with your IDIR and I'll update LaunchDarkly to target you only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/gcbrun |
Temporary Url for review: https://business-filings-dev--pr-703-athj4a1p.web.app SB says, try this: https://business-filings-dev--pr-703-athj4a1p.web.app/BC0870895?param1=severin¶m2=123 It should redirect only if the FF is True for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, thanks for this quick PR !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 👍
got to this a bit late but looks good |
Issue #: bcgov/entity#24423
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).