Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
18027 AGM Location change #551
18027 AGM Location change #551
Changes from all commits
ece0469
be4c033
7a3480b
8320add
4885122
b9cb328
43b95ce
9ab5884
7f5abe0
2779751
630a9c0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validates when user moves away (on blur)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still doesn't work as expected: I see a validation error as soon as I enter "2" (for 2022). I should see the error after I leave the component (ie, lazy-validation if this was in a v-form), or when I click File Now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try again. code should be updated now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, works perfectly now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
component for Agm year
Check warning on line 244 in src/components/Dashboard/TodoList.vue
GitHub Actions / linting (20.5.1)
Check warning on line 252 in src/components/Dashboard/TodoList.vue
GitHub Actions / linting (20.5.1)
Check warning on line 318 in src/components/Dashboard/TodoList.vue
GitHub Actions / linting (20.5.1)
Check warning on line 400 in src/components/Dashboard/TodoList.vue
GitHub Actions / linting (20.5.1)
Check warning on line 409 in src/components/Dashboard/TodoList.vue
GitHub Actions / linting (20.5.1)
Check warning on line 426 in src/components/Dashboard/TodoList.vue
GitHub Actions / linting (20.5.1)
Check warning on line 448 in src/components/Dashboard/TodoList.vue
GitHub Actions / linting (20.5.1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this if we can't save a draft?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... Unless payment fails, and then can we resume it?If payment fails then the To Do list will show a button to resume payment, which will redirect the user to the Pay URL (not this filing), so there's no need to handle resuming a draft. Phew!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^ This comment isn't blocking this PR or ticket, but it will block the next ticket (18161).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't an issue, but I'd like to see what it looks like to confirm that there is a retry payment button (and possibly a cancel payment button, but that will cause another issue).
Do you have a screenshot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see a screenshot of a pending AGM Location Change filing in the To Do list -- the action buttons may need to be updated (which we'd do in the next ticket).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes Sev. Trying to figure out how I can get a pending filing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll have to simulate a pay error. How about we leave this for the next ticket? Add a specific comment in the next ticket to look at this. Let's move on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrap in a
div
to show tooltip when list item is disabledThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good:
In good standing:
Not in good standing:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format current date as UX pin