-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
18689 More Amalgamation fixes/updates #614
Merged
JazzarKarim
merged 5 commits into
bcgov:main
from
JazzarKarim:18689-more-amalgamation-fixes
Jan 9, 2024
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a4136d1
Fixed Review and Confirm page validation
JazzarKarim 9e2c30a
Re-fetch business table data on file and pay
JazzarKarim 00e1025
updated package version
JazzarKarim 4bbb2c9
removed debug code
JazzarKarim 6bfea4f
Fixed re-fetching issue
JazzarKarim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -588,17 +588,20 @@ export const useStore = defineStore('store', { | |
|
||
/** Whether all the amalgamation (regular) steps are valid. */ | ||
isAmalgamationRegularValid (): boolean { | ||
// *** TODO: add checks for review page components | ||
const isFolioNumberValid = !this.isPremiumAccount || this.getFolioNumberValid | ||
const isCertifyValid = this.getCertifyState.valid && !!this.getCertifyState.certifiedBy | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Found this missing. Now we're not able to file and pay if the review and confirm page is invalid. |
||
const isCourtOrderValid = this.isRoleStaff ? this.getCourtOrderStep.valid : true | ||
const isFolioNumberValid = !this.isPremiumAccount || this.getFolioNumberValid | ||
const isStaffPaymentValid = this.isRoleStaff ? this.getStaffPaymentStep.valid : true | ||
|
||
return ( | ||
this.isAmalgamationInformationRegValid && | ||
this.isDefineCompanyValid && | ||
this.isAddPeopleAndRolesValid && | ||
this.isCreateShareStructureValid && | ||
isFolioNumberValid && | ||
isCertifyValid && | ||
isCourtOrderValid && | ||
isFolioNumberValid && | ||
isStaffPaymentValid && | ||
this.getAmalgamationCourtApprovalValid | ||
) | ||
}, | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was missing. We want to re-fetch this.