-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12570 Add transactional folio number to SP/GP registration filings #410
Conversation
Add tests for registration review and confirm view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks great!
Is anything needed to save the TFN in the filing and to possibly parse it from a resumed filing? See
// NB: Premium account is mutually exclusive with staff role. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good and clean!
This reverts commit c98aa0a.
remove business folio number from sp/gp registrations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge after final comment tweaks.
Issue #: /bcgov/entity#12570
Description of changes:
SP/GP Registration filings:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).