Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12570 Add transactional folio number to SP/GP registration filings #410

Merged
merged 9 commits into from
Jun 21, 2022

Conversation

lambert-alex
Copy link
Contributor

@lambert-alex lambert-alex commented Jun 15, 2022

Issue #: /bcgov/entity#12570

Description of changes:
SP/GP Registration filings:

  1. Added Transactional Folio Number component in the Review and Confirm view for premium users.
  2. Added unit tests for Registration Review Confirm view as there was no tests for it.
  3. Remove business folio number for SP/GP registrations
  4. Version number = 4.0.20

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great!

Is anything needed to save the TFN in the filing and to possibly parse it from a resumed filing? See

// NB: Premium account is mutually exclusive with staff role.
.

@lambert-alex
Copy link
Contributor Author

lambert-alex commented Jun 15, 2022

The code looks great!

Is anything needed to save the TFN in the filing and to possibly parse it from a resumed filing? See

// NB: Premium account is mutually exclusive with staff role.

.

I will check I don't know. From what I can tell I don't think I need to.

Copy link
Contributor

@lewischenstudio lewischenstudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good and clean!

@lambert-alex lambert-alex marked this pull request as draft June 16, 2022 19:34
remove business folio number from sp/gp registrations
@lambert-alex lambert-alex marked this pull request as ready for review June 20, 2022 22:24
Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge after final comment tweaks.

@lambert-alex lambert-alex merged commit a1660d9 into bcgov:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants