18641 More unit tests (#618)

* - app version = 5.6.32 - added Amalgamation Mixin unit tests - updated some status messages (per Yui) - updated some rules (per Yui) - added more Business Table unit tests (disabled until future) - misc updates * - added missing rule to list --------- Co-authored-by: Severin Beauvais <[email protected]>
bcgov · Jan 10, 2024 · d8e76a0 · d8e76a0
1 parent 55f03dc
commit d8e76a0
Show file tree

Hide file tree

Showing 10 changed files with 360 additions and 22 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "business-create-ui",
-  "version": "5.6.31",
+  "version": "5.6.32",
   "private": true,
   "appName": "Create UI",
   "sbcName": "SBC Common Components",

diff --git a/src/components/Amalgamation/BusinessStatus.vue b/src/components/Amalgamation/BusinessStatus.vue
@@ -58,16 +58,15 @@ export default class BusinessStatus extends Vue {
           'Form Horizontal amalgamation. '
 
       case AmlStatuses.ERROR_FOREIGN_UNLIMITED:
-        return 'A foreign corporation must not amalgamate with a limited company and continue as ' +
-          'an Unlimited Liability Company.'
+        return 'A foreign corporation must not amalgamate with a BC Company and continue as an ' +
+          'Unlimited Liability Company.'
 
       case AmlStatuses.ERROR_FOREIGN_UNLIMITED2:
         return 'A BC Company cannot amalgamate with an existing foreign corporation to form a BC ' +
           'Unlimited Liability Company.'
 
       case AmlStatuses.ERROR_FOREIGN_UNLIMITED3:
-        return 'A BC Company cannot amalgamate with a foreign company to form a BC Unlimited ' +
-          'Liability Company.'
+        return 'A BC Unlimited Liability Company cannot amalgamate with a foreign company.'
 
       case AmlStatuses.ERROR_FUTURE_EFFECTIVE_FILING:
         return 'This business has a future effective filing. It cannot be part of an amalgamation ' +

diff --git a/src/mixin-tester.vue b/src/mixin-tester.vue
@@ -4,10 +4,10 @@
 
 <script lang="ts">
 import { Component, Mixins } from 'vue-property-decorator'
-import { DateMixin, FilingTemplateMixin } from '@/mixins'
+import { AmalgamationMixin, DateMixin, FilingTemplateMixin } from '@/mixins'
 
 @Component({})
-export default class MixinTester extends Mixins(DateMixin, FilingTemplateMixin) {}
+export default class MixinTester extends Mixins(AmalgamationMixin, DateMixin, FilingTemplateMixin) {}
 </script>
 
 <style>

diff --git a/src/mixins/amalgamation-mixin.ts b/src/mixins/amalgamation-mixin.ts
@@ -21,7 +21,7 @@ export default class AmalgamationMixin extends Vue {
 
   @Action(useStore) setAmalgamatingBusinesses!: (x: Array<any>) => void
 
-  /** Iterable array of rule functions, sorted by importance. */
+  /** Iterable array of rule functions, in order of processing. */
   readonly rules = [
     this.notAffiliated,
     this.notHistorical,
@@ -33,6 +33,7 @@ export default class AmalgamationMixin extends Vue {
     this.cccMismatch,
     this.foreignUnlimited2,
     this.xproUlcCcc,
+    this.foreignUnlimited3,
     this.needBcCompany,
     this.foreignHorizontal
   ]
@@ -91,9 +92,9 @@ export default class AmalgamationMixin extends Vue {
     return null
   }
 
-  /** Disallow if foreign into ULC if there is also a limited company. */
+  /** Disallow if foreign and there is also a BC company, into ULC. */
   foreignUnlimited (business: AmalgamatingBusinessIF): AmlStatuses {
-    if (business.type === AmlTypes.FOREIGN && this.isTypeBcUlcCompany && this.isAnyLimited) {
+    if (business.type === AmlTypes.FOREIGN && this.isAnyBcCompany && this.isTypeBcUlcCompany) {
       return AmlStatuses.ERROR_FOREIGN_UNLIMITED
     }
     return null
@@ -107,9 +108,14 @@ export default class AmalgamationMixin extends Vue {
     return null
   }
 
-  /** Disallow if foreign into ULC if there is also a limited company. */
+  /** Disallow if BC and there is also a foreign, into ULC. */
   foreignUnlimited2 (business: AmalgamatingBusinessIF): AmlStatuses {
-    if (business.type === AmlTypes.FOREIGN && this.isTypeBcUlcCompany && this.isAnyLimited) {
+    if (
+      business.type === AmlTypes.LEAR &&
+      business.legalType === CorpTypeCd.BC_COMPANY &&
+      this.isAnyForeign &&
+      this.isTypeBcUlcCompany
+    ) {
       return AmlStatuses.ERROR_FOREIGN_UNLIMITED2
     }
     return null
@@ -138,7 +144,7 @@ export default class AmalgamationMixin extends Vue {
     return null
   }
 
-  /** Disallow if there are no BC Companies. */
+  /** Disallow if there are no BC companies. */
   needBcCompany (): AmlStatuses {
     if (!this.isAnyBcCompany) {
       return AmlStatuses.ERROR_NEED_BC_COMPANY

diff --git a/tests/unit/BusinessStatus.spec.ts b/tests/unit/BusinessStatus.spec.ts
@@ -27,7 +27,7 @@ describe('Business Status', () => {
     {
       label: 'Error Foreign Unlimited',
       status: AmlStatuses.ERROR_FOREIGN_UNLIMITED,
-      tooltip: 'A foreign corporation must not amalgamate with a limited company and continue as'
+      tooltip: 'A foreign corporation must not amalgamate with a BC Company and continue as an'
     },
     {
       label: 'Error Foreign Unlimited 2',
@@ -37,7 +37,7 @@ describe('Business Status', () => {
     {
       label: 'Error Foreign Unlimited 3',
       status: AmlStatuses.ERROR_FOREIGN_UNLIMITED3,
-      tooltip: 'A BC Company cannot amalgamate with a foreign company to form a BC Unlimited'
+      tooltip: 'A BC Unlimited Liability Company cannot amalgamate with a foreign company.'
     },
     {
       label: 'Error Future Effective Filing',

diff --git a/tests/unit/BusinessTable.spec.ts b/tests/unit/BusinessTable.spec.ts
@@ -1,9 +1,10 @@
-import { AmlRoles, AmlTypes } from '@/enums'
+import { AmlRoles, AmlStatuses, AmlTypes } from '@/enums'
 import { wrapperFactory } from '../vitest-wrapper-factory'
 import BusinessTable from '@/components/Amalgamation/BusinessTable.vue'
 import { CorpTypeCd } from '@bcrs-shared-components/corp-type-module'
+import AmalgamationMixin from '@/mixins/amalgamation-mixin'
 
-describe('Business Table', () => {
+describe('Business Table - display', () => {
   it('displays correctly when there are no amalgamating businesses', () => {
     const wrapper = wrapperFactory(
       BusinessTable,
@@ -167,3 +168,79 @@ describe('Business Table', () => {
     })
   }
 })
+
+// *** FUTURE: get this working
+// ATM, local rules are mocked (eg, wrapper.vm.notAffiliated()), but not the actual rules in the mixin.
+// It's probably this: https://vitest.dev/guide/mocking.html#mocking-pitfalls.
+// Maybe try vi.mock() to mock the imported mixin?
+describe.skip('Business Table - rule evaluation', () => {
+  let wrapper: any
+
+  const rules = [
+    { methodName: 'notAffiliated', error: AmlStatuses.ERROR_NOT_AFFILIATED },
+    { methodName: 'notHistorical', error: AmlStatuses.ERROR_HISTORICAL },
+    { methodName: 'notInGoodStanding', error: AmlStatuses.ERROR_NOT_IN_GOOD_STANDING },
+    { methodName: 'limitedRestoration', error: AmlStatuses.ERROR_LIMITED_RESTORATION },
+    { methodName: 'futureEffectiveFiling', error: AmlStatuses.ERROR_FUTURE_EFFECTIVE_FILING },
+    { methodName: 'foreign', error: AmlStatuses.ERROR_FOREIGN },
+    { methodName: 'foreignUnlimited', error: AmlStatuses.ERROR_FOREIGN_UNLIMITED },
+    { methodName: 'cccMismatch', error: AmlStatuses.ERROR_CCC_MISMATCH },
+    { methodName: 'foreignUnlimited2', error: AmlStatuses.ERROR_FOREIGN_UNLIMITED2 },
+    { methodName: 'xproUlcCcc', error: AmlStatuses.ERROR_XPRO_ULC_CCC },
+    { methodName: 'needBcCompany', error: AmlStatuses.ERROR_NEED_BC_COMPANY },
+    { methodName: 'foreignHorizontal', error: AmlStatuses.ERROR_FOREIGN_HORIZONTAL }
+  ]
+
+  beforeAll(() => {
+    wrapper = wrapperFactory(
+      BusinessTable,
+      null,
+      {
+        amalgamation: {
+          amalgamatingBusinesses: [{ /* dummy business */ }]
+        },
+        tombstone: {
+          keycloakRoles: ['staff']
+        }
+      }
+    )
+
+    // mock all rules to return their error
+    for (let i = 0; i < rules.length; i++) {
+      vi.spyOn(wrapper.vm, rules[i].methodName).mockReturnValue(rules[i].error)
+    }
+    // *** these work
+    console.log('*** value1 = ', wrapper.vm.notAffiliated())
+    console.log('*** value2 = ', wrapper.vm.notHistorical())
+    console.log('*** value3 = ', wrapper.vm.notInGoodStanding())
+
+    // *** this doesn't work ("is not a function")
+    console.log('*** value4 = ', (AmalgamationMixin as any).notAffiliated())
+  })
+
+  it('has the expected number of rules', () => {
+    expect(wrapper.vm.rules.length).toBe(rules.length)
+  })
+
+  // check each rule sequentially
+  for (let i = 0; i < rules.length; i++) {
+    it.skip(`fails rule "${rules[i].methodName}"`, () => {
+      // first, verify that current rule fails
+      expect(wrapper.vm.businesses[0].status).toBe(rules[i].error)
+
+      // now override rule to return null
+      vi.spyOn(wrapper.vm, rules[i].methodName).mockReturnValue(null)
+
+      // if this is the last rule...
+      if (i === (rules.length - 1)) {
+        // verify that no rules have failed
+        expect(wrapper.vm.businesses[0].status).toBe(AmlStatuses.OK)
+      } else {
+        // verify that another rule has failed
+        expect(wrapper.vm.businesses[0].status).toBe(rules[i + 1].error)
+      }
+
+      wrapper.destroy()
+    })
+  }
+})