Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile chunk_limit and single_download_limit #332

Merged
merged 14 commits into from
Oct 5, 2023
Merged

Reconcile chunk_limit and single_download_limit #332

merged 14 commits into from
Oct 5, 2023

Commits on Sep 26, 2023

  1. Set chunk_limit default to single_download_limit 

    * Also have check_chunk_limit return the chunk limit to avoid repeated calls to bcdc_single_download_limit.
* Use check_chunk_limit in paginated requests
    @ateucher
    ateucher committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    316dff3 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. document

    @ateucher
    ateucher committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    213ad62 View commit details
    Browse the repository at this point in the history

  2. Fix check_chunk_limit 

    * Don't use a default
* Return chunk_limit early if chunk_value is NULL
    @ateucher
    ateucher committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    1522a7a View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Deprecate bcdata.single_download_limit option 

    * wrapper function to consult the option and warn once per session if it is set.
* Use check_chunk_limit throughout to be more efficient in checking both options
* Update documentation
    @ateucher
    ateucher committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    cd0b9fe View commit details
    Browse the repository at this point in the history

  2. Document, update NEWS

    @ateucher
    ateucher committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    967cd3a View commit details
    Browse the repository at this point in the history

  3. Update to testthat edition 3

    @ateucher
    ateucher committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    08fb4ce View commit details
    Browse the repository at this point in the history

  4. Test changes to bcdata.single_download_limit option, use snapshot test

    @ateucher
    ateucher committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    7370877 View commit details
    Browse the repository at this point in the history

  5. Update tests for testthat 3e 

    * remove context()
* update expect_is() to expect_s3_class()
  and expect_type()
    @ateucher
    ateucher committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    030a37c View commit details
    Browse the repository at this point in the history

  6. Unset BCDC_KEY so doesn't affect message snapshot

    @ateucher
    ateucher committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    08a2fec View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Update R/bcdc_options.R 

    Co-authored-by: Stephanie Hazlitt <[email protected]>
    @ateucher @stephhazlitt
    ateucher and stephhazlitt authored Oct 4, 2023
    Configuration menu
    Copy the full SHA
    9ebfe1d View commit details
    Browse the repository at this point in the history

  2. Update R/bcdc_options.R 

    Co-authored-by: Stephanie Hazlitt <[email protected]>
    @ateucher @stephhazlitt
    ateucher and stephhazlitt authored Oct 4, 2023
    Configuration menu
    Copy the full SHA
    74a4d74 View commit details
    Browse the repository at this point in the history

  3. Update R/bcdc_options.R 

    Co-authored-by: Stephanie Hazlitt <[email protected]>
    @ateucher @stephhazlitt
    ateucher and stephhazlitt authored Oct 4, 2023
    Configuration menu
    Copy the full SHA
    80cba2c View commit details
    Browse the repository at this point in the history

  4. document

    @ateucher
    ateucher committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    9e7bd69 View commit details
    Browse the repository at this point in the history

  5. Comments for clarity and future cleanup

    @ateucher
    ateucher committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    0388ce3 View commit details
    Browse the repository at this point in the history