-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconcile chunk_limit and single_download_limit #332
Merged
Merged
Commits on Sep 26, 2023
-
Set chunk_limit default to single_download_limit
* Also have check_chunk_limit return the chunk limit to avoid repeated calls to bcdc_single_download_limit. * Use check_chunk_limit in paginated requests
Configuration menu - View commit details
-
Copy full SHA for 316dff3 - Browse repository at this point
Copy the full SHA 316dff3View commit details
Commits on Sep 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 213ad62 - Browse repository at this point
Copy the full SHA 213ad62View commit details -
* Don't use a default * Return chunk_limit early if chunk_value is NULL
Configuration menu - View commit details
-
Copy full SHA for 1522a7a - Browse repository at this point
Copy the full SHA 1522a7aView commit details
Commits on Oct 3, 2023
-
Deprecate bcdata.single_download_limit option
* wrapper function to consult the option and warn once per session if it is set. * Use check_chunk_limit throughout to be more efficient in checking both options * Update documentation
Configuration menu - View commit details
-
Copy full SHA for cd0b9fe - Browse repository at this point
Copy the full SHA cd0b9feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 967cd3a - Browse repository at this point
Copy the full SHA 967cd3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08fb4ce - Browse repository at this point
Copy the full SHA 08fb4ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7370877 - Browse repository at this point
Copy the full SHA 7370877View commit details -
* remove context() * update expect_is() to expect_s3_class() and expect_type()
Configuration menu - View commit details
-
Copy full SHA for 030a37c - Browse repository at this point
Copy the full SHA 030a37cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08a2fec - Browse repository at this point
Copy the full SHA 08a2fecView commit details
Commits on Oct 4, 2023
-
Co-authored-by: Stephanie Hazlitt <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9ebfe1d - Browse repository at this point
Copy the full SHA 9ebfe1dView commit details -
Co-authored-by: Stephanie Hazlitt <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 74a4d74 - Browse repository at this point
Copy the full SHA 74a4d74View commit details -
Co-authored-by: Stephanie Hazlitt <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 80cba2c - Browse repository at this point
Copy the full SHA 80cba2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e7bd69 - Browse repository at this point
Copy the full SHA 9e7bd69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0388ce3 - Browse repository at this point
Copy the full SHA 0388ce3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.