Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: person credential workflow pt. 2 #973

Merged
merged 15 commits into from
Mar 14, 2023

Conversation

amanji
Copy link
Contributor

@amanji amanji commented Mar 13, 2023

This adds a fix when the person credential workflow is activated from the Home Screen

@amanji amanji requested a review from jleach March 13, 2023 22:22
bifold Outdated Show resolved Hide resolved
Signed-off-by: Akiff Manji <[email protected]>
@amanji amanji force-pushed the person-credential-workflow-fix branch from 355d4f4 to 47c7569 Compare March 13, 2023 23:43
@amanji amanji requested a review from cvarjao March 13, 2023 23:46
Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a duplicated useEffect, other than that LGTM

app/src/components/AddCredentialSlider.tsx Outdated Show resolved Hide resolved
app/src/components/CredentialOfferTrigger.tsx Outdated Show resolved Hide resolved
@amanji amanji requested a review from bryce-mcmath March 14, 2023 00:10
bryce-mcmath
bryce-mcmath previously approved these changes Mar 14, 2023
Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slick! Nice work

@amanji amanji marked this pull request as draft March 14, 2023 00:26
@amanji amanji marked this pull request as ready for review March 14, 2023 03:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bryce-mcmath bryce-mcmath self-requested a review March 14, 2023 17:20
@amanji amanji merged commit 6d262cb into bcgov:main Mar 14, 2023
jcdrouin21 added a commit to CQEN-QDCE/portefeuille-mobile-qc that referenced this pull request Apr 13, 2023
* fix: person credential workflow fix (bcgov#960)

* update bifold submodule (bcgov#961)

Signed-off-by: wadeking98 <[email protected]>

* feat: added person credential to preview notification screen with v1.1 branding (bcgov#959)

Signed-off-by: wadeking98 <[email protected]>

* fix: match logoSec sizing to bifold, run lint (bcgov#963)

Signed-off-by: Bryce McMath <[email protected]>

* fix: person credential workflow pt. 2 (bcgov#973)

* chore: update bifold submodule (bcgov#977)

Signed-off-by: Bryce McMath <[email protected]>

* chore: bump version number to 1.0.8 (bcgov#982)

Signed-off-by: Bryce McMath <[email protected]>

* chore: remove flipper, update bifold submodule (bcgov#985)

Signed-off-by: Bryce McMath <[email protected]>

* fix: add scroll to splash screen for larger font and display size (bcgov#993)

Signed-off-by: Bryce McMath <[email protected]>

* chore: update bifold submodule (bcgov#998)

Signed-off-by: Bryce McMath <[email protected]>

* fix: change product name to BCWallet from AriesBifold (bcgov#994)

Signed-off-by: Bryce McMath <[email protected]>

* chore: add storybook to bc-wallet-mobile (bcgov#991)

Signed-off-by: Clécio Varjão <[email protected]>
Signed-off-by: Bryce McMath <[email protected]>
Co-authored-by: Clécio Varjão <[email protected]>

* fix: android and ios build and pipeline issues (bcgov#1006)

Signed-off-by: Bryce McMath <[email protected]>

* fix: possible fix for android crashing (bcgov#1007)

Signed-off-by: Bryce McMath <[email protected]>

* ci: update GHA (bcgov#1009)

Signed-off-by: Clécio Varjão <[email protected]>

* Updated Smoke test in build pipeline for new iOS app name (bcgov#1010)

Signed-off-by: Sheldon Regular <[email protected]>

* chore: update GHA build file name and watched files on PR (bcgov#1011)

Signed-off-by: Bryce McMath <[email protected]>

* Support for bifold new monorepo structure (bcgov#1012)

Signed-off-by: Clécio Varjão <[email protected]>

* chore: update bifold submodule (bcgov#1020)

Signed-off-by: Bryce McMath <[email protected]>

* chore: peg ios build to xcode 14.2

Signed-off-by: Jason C. Leach <[email protected]>

* updated branding for traction agent (bcgov#1025)

Signed-off-by: wadeking98 <[email protected]>

* chore: update bifold submodule (bcgov#1027)

Signed-off-by: Bryce McMath <[email protected]>

* chore: add patch to support xcode 14.3 (bcgov#1023)

Signed-off-by: Jason C. Leach <[email protected]>

* Small fix

Signed-off-by: Jean-Christophe <[email protected]>

* Fix occurence of bcwallet

Signed-off-by: Jean-Christophe <[email protected]>

* Fix android setup - portefeuilleqc reference

Signed-off-by: Jean-Christophe <[email protected]>

---------

Signed-off-by: wadeking98 <[email protected]>
Signed-off-by: Bryce McMath <[email protected]>
Signed-off-by: Clécio Varjão <[email protected]>
Signed-off-by: Sheldon Regular <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jean-Christophe <[email protected]>
Co-authored-by: Akiff Manji <[email protected]>
Co-authored-by: Wade King <[email protected]>
Co-authored-by: Bryce McMath <[email protected]>
Co-authored-by: Clécio Varjão <[email protected]>
Co-authored-by: Sheldon Regular <[email protected]>
Co-authored-by: Jason C. Leach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants