-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: person credential workflow pt. 2 #973
fix: person credential workflow pt. 2 #973
Conversation
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
… list Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
355d4f4
to
47c7569
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a duplicated useEffect
, other than that LGTM
Signed-off-by: Akiff Manji <[email protected]>
Signed-off-by: Akiff Manji <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slick! Nice work
Signed-off-by: Akiff Manji <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
* fix: person credential workflow fix (bcgov#960) * update bifold submodule (bcgov#961) Signed-off-by: wadeking98 <[email protected]> * feat: added person credential to preview notification screen with v1.1 branding (bcgov#959) Signed-off-by: wadeking98 <[email protected]> * fix: match logoSec sizing to bifold, run lint (bcgov#963) Signed-off-by: Bryce McMath <[email protected]> * fix: person credential workflow pt. 2 (bcgov#973) * chore: update bifold submodule (bcgov#977) Signed-off-by: Bryce McMath <[email protected]> * chore: bump version number to 1.0.8 (bcgov#982) Signed-off-by: Bryce McMath <[email protected]> * chore: remove flipper, update bifold submodule (bcgov#985) Signed-off-by: Bryce McMath <[email protected]> * fix: add scroll to splash screen for larger font and display size (bcgov#993) Signed-off-by: Bryce McMath <[email protected]> * chore: update bifold submodule (bcgov#998) Signed-off-by: Bryce McMath <[email protected]> * fix: change product name to BCWallet from AriesBifold (bcgov#994) Signed-off-by: Bryce McMath <[email protected]> * chore: add storybook to bc-wallet-mobile (bcgov#991) Signed-off-by: Clécio Varjão <[email protected]> Signed-off-by: Bryce McMath <[email protected]> Co-authored-by: Clécio Varjão <[email protected]> * fix: android and ios build and pipeline issues (bcgov#1006) Signed-off-by: Bryce McMath <[email protected]> * fix: possible fix for android crashing (bcgov#1007) Signed-off-by: Bryce McMath <[email protected]> * ci: update GHA (bcgov#1009) Signed-off-by: Clécio Varjão <[email protected]> * Updated Smoke test in build pipeline for new iOS app name (bcgov#1010) Signed-off-by: Sheldon Regular <[email protected]> * chore: update GHA build file name and watched files on PR (bcgov#1011) Signed-off-by: Bryce McMath <[email protected]> * Support for bifold new monorepo structure (bcgov#1012) Signed-off-by: Clécio Varjão <[email protected]> * chore: update bifold submodule (bcgov#1020) Signed-off-by: Bryce McMath <[email protected]> * chore: peg ios build to xcode 14.2 Signed-off-by: Jason C. Leach <[email protected]> * updated branding for traction agent (bcgov#1025) Signed-off-by: wadeking98 <[email protected]> * chore: update bifold submodule (bcgov#1027) Signed-off-by: Bryce McMath <[email protected]> * chore: add patch to support xcode 14.3 (bcgov#1023) Signed-off-by: Jason C. Leach <[email protected]> * Small fix Signed-off-by: Jean-Christophe <[email protected]> * Fix occurence of bcwallet Signed-off-by: Jean-Christophe <[email protected]> * Fix android setup - portefeuilleqc reference Signed-off-by: Jean-Christophe <[email protected]> --------- Signed-off-by: wadeking98 <[email protected]> Signed-off-by: Bryce McMath <[email protected]> Signed-off-by: Clécio Varjão <[email protected]> Signed-off-by: Sheldon Regular <[email protected]> Signed-off-by: Jason C. Leach <[email protected]> Signed-off-by: Jean-Christophe <[email protected]> Co-authored-by: Akiff Manji <[email protected]> Co-authored-by: Wade King <[email protected]> Co-authored-by: Bryce McMath <[email protected]> Co-authored-by: Clécio Varjão <[email protected]> Co-authored-by: Sheldon Regular <[email protected]> Co-authored-by: Jason C. Leach <[email protected]>
This adds a fix when the person credential workflow is activated from the Home Screen