fix: fix issue when action run on main #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
cvarjao
reviewed
Oct 24, 2024
| end_ref="HEAD" | ||
| fi | ||
|
|
||
| change_count=$(git diff --name-only origin/main..${end_ref} | grep -E '^(app/.*)|(.yarn/.*)|(.github/workflows/.*)' | wc -l) |
There was a problem hiding this comment.
can you make origin/main dynamic? We can use ${GITHUB_BASE_REF:-HEAD} since GITHUB_BASE_REF is only provided for PRs, the :-HEAD will head the default to HEAD when not from a PR.
There was a problem hiding this comment.
Fixed, I had to include origin otherwise git complains if it being ambitious:
Run # On main branch, compare with the previous
Comparing main with HEAD
fatal: ambiguous argument 'main..HEAD': unknown revision or path not in the working tree.I also tested origin/HEAD..HEAD^ works.
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
|
cvarjao
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When run on main the diff can not be agains the same ref.