Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Endorser protocol for Issuer Agency #11

Merged
merged 16 commits into from
May 13, 2021
Merged

Conversation

amanji
Copy link
Contributor

@amanji amanji commented May 4, 2021

Adds endorsement signing request from Issuer by an Endorser, allowing the Issuer with non-edit roles to author schemas to ledger.

Signed-off-by: Akiff Manji [email protected]

@amanji amanji requested a review from esune May 4, 2021 21:55
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far 👍🏻

Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far

@amanji amanji marked this pull request as ready for review May 12, 2021 18:38
@amanji amanji changed the title First pass of Endorser protocols Endorser protocol for Issuer Agency May 12, 2021
@amanji amanji requested a review from esune May 12, 2021 18:40
@amanji amanji linked an issue May 12, 2021 that may be closed by this pull request
@esune esune linked an issue May 12, 2021 that may be closed by this pull request
agency/src/services/aries-agent/aries-agent.class.ts Outdated Show resolved Hide resolved
agency/src/services/aries-agent/aries-agent.class.ts Outdated Show resolved Hide resolved
@@ -645,4 +724,60 @@ export class AriesAgent {
);
}
}

// TODO: Need to type response
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to type the response before merging, or leave it for later (e.g.: new issue)?

agency/src/services/event/events.service.ts Show resolved Hide resolved
agency/src/services/index.ts Outdated Show resolved Hide resolved
agency/src/services/schema/schema.class.ts Outdated Show resolved Hide resolved
agency/src/services/schema/schema.class.ts Outdated Show resolved Hide resolved
@amanji amanji merged commit bb809b6 into bcgov:main May 13, 2021
@amanji amanji deleted the endorse branch August 4, 2021 23:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endorsing functionality - endorser side Endorsing functionality - tenant side
2 participants