Move test resources to correct modules #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core:src/test/data/org/bouncycastle/tsp/test/FileDaFirmare.data used by pkix:org.bouncycastle.tsp.test.CMSTimeStampedDataGeneratorTest
The tests use classes from pkix, eg: prov/src/main/java/org/bouncycastle/ocsp/Req.java
pkix/src/test/java/org/bouncycastle/cms/test/BcSignedDataTest.java BcSignedDataTest. testCounterSig BcSignedDataTest. testEncapsulatedSample BcSignedDataTest. testSamples
….AllTests pkix/src/test/java/org/bouncycastle/eac/test/AllTests.java
…t.rsa3.RSA3CertTest prov/src/test/java/org/bouncycastle/jce/provider/test/rsa3/RSA3CertTest.java org.bouncycastle.jce.provider.test.AllTests > org.bouncycastle.jce.provider.test.rsa3.RSA3CertTest.testI FAILED org.bouncycastle.jcajce.provider.asymmetric.x509.CertificateFactory$ExCertificateException at RSA3CertTest.java:113 Caused by: java.io.IOException at RSA3CertTest.java:113 org.bouncycastle.jce.provider.test.AllTests > org.bouncycastle.jce.provider.test.rsa3.RSA3CertTest.testJ FAILED org.bouncycastle.jcajce.provider.asymmetric.x509.CertificateFactory$ExCertificateException at RSA3CertTest.java:113 Caused by: java.io.IOException at RSA3CertTest.java:113
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of tests fail when running the Gradle build because the resources aren't in the correct module (many of them are in
corewhen they should be inpkixorprov. These commits move the resources to the correct locations.