Relax certificate test - was dependent on build-machine timezone #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my London-based JVM, the date was actually Apr 19th, and the asserted string did not match.
|
Probably your result is showing there's something timezone-related wrong here, so we might better try and fix it to always give the GMT date in the error message. |
Yup - rather than relaxing the test, the message can become always GMT (and with a well-specified, non-locale dependent formatting), and then test won't be TimeZone/Locale specific - I can submit another PR with that if you like? |
rtyley
added a commit
to rtyley/spongycastle
that referenced
this pull request
Jan 8, 2014
In my London-based JVM, the date was actually Apr 19th, and the asserted string in NistCertPathTest did not match. This is an alternative to this prior pull-request, which just relaxed the test condition to ignore the date: bcgit#45 (comment)
rtyley
added a commit
to rtyley/spongycastle
that referenced
this pull request
Jan 8, 2014
In my London-based JVM, the date was actually Apr 19th, and the asserted string in NistCertPathTest did not match. This is an alternative to this prior pull-request, which just relaxed the test condition to ignore the date: bcgit#45 (comment)
rtyley
added a commit
to rtyley/spongycastle
that referenced
this pull request
Jan 9, 2014
In my London-based JVM, the date was actually Apr 19th, and the asserted string in NistCertPathTest did not match. This is an alternative to this prior pull-request, which just relaxed the test condition to ignore the date: bcgit#45 (comment)
rtyley
added a commit
to rtyley/spongycastle
that referenced
this pull request
Jan 12, 2014
In my London-based JVM, the date was actually Apr 19th, and the asserted string in NistCertPathTest did not match. This is an alternative to this prior pull-request, which just relaxed the test condition to ignore the date: bcgit#45 (comment)
rtyley
added a commit
to rtyley/spongycastle
that referenced
this pull request
Jan 19, 2014
In my London-based JVM, the date was actually Apr 19th, and the asserted string in NistCertPathTest did not match. This is an alternative to this prior pull-request, which just relaxed the test condition to ignore the date: bcgit#45 (comment)
rtyley
added a commit
to rtyley/spongycastle
that referenced
this pull request
Jan 19, 2014
In my London-based JVM, the date was actually Apr 19th, and the asserted string in NistCertPathTest did not match. This is an alternative to this prior pull-request, which just relaxed the test condition to ignore the date: bcgit#45 (comment)
rtyley
added a commit
to rtyley/spongycastle
that referenced
this pull request
Jan 19, 2014
In my London-based JVM, the date was actually Apr 19th, and the asserted string in NistCertPathTest did not match. This is an alternative to this prior pull-request, which just relaxed the test condition to ignore the date: bcgit#45 (comment)
rtyley
added a commit
to rtyley/spongycastle
that referenced
this pull request
Jan 22, 2014
In my London-based JVM, the date was actually Apr 19th, and the asserted string in NistCertPathTest did not match. This is an alternative to this prior pull-request, which just relaxed the test condition to ignore the date: bcgit#45 (comment)
rtyley
added a commit
to rtyley/spongycastle
that referenced
this pull request
Jan 22, 2014
In my London-based JVM, the date was actually Apr 19th, and the asserted string in NistCertPathTest did not match. This is an alternative to this prior pull-request, which just relaxed the test condition to ignore the date: bcgit#45 (comment)
|
Dropped in favour of #48 , thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my London-based JVM, the date was actually Apr 19th, and the asserted string did not match.