Bug kube-logging#1616: Ensured that the custom PVC source details spe…

…cified in the fluentd.extraVolumes.volume.pvc.source.claimName of the fluentd definition are honoured, instead of always attempting to create a new PVC.

Signed-off-by: Bhaskar Reddy Byreddy <[email protected]>

pkg/resources/fluentd/statefulset.go

@@ -78,12 +78,12 @@ func (r *Reconciler) statefulset() (runtime.Object, reconciler.DesiredState, err
 }
 
 func isPersistentVolumeClaimSpecEmpty(pvcSpec corev1.PersistentVolumeClaimSpec) bool {
-	searilizedPvcSpec, _ := json.Marshal(pvcSpec)
+	searilizedPvcSpec, _ := json.Marshal(pvcSpec) // Json serialization should not fail, hence the error is ignored
 	return string(searilizedPvcSpec) == `{"resources":{}}`
 }
 
 func isPersistentVolumeSourceEmpty(pvcSource corev1.PersistentVolumeClaimVolumeSource) bool {
-	searilizedPvcSource, _ := json.Marshal(pvcSource)
+	searilizedPvcSource, _ := json.Marshal(pvcSource) // Json serialization should not fail, hence the error is ignored
 	return string(searilizedPvcSource) == `{}`
 }