Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Angus Mail #489

Closed
PascalSchumacher opened this issue Dec 28, 2023 · 9 comments
Closed

Update to Angus Mail #489

PascalSchumacher opened this issue Dec 28, 2023 · 9 comments
Labels
dependencies Pull requests that update a dependency file Priority-Low
Milestone

Comments

@PascalSchumacher
Copy link
Contributor

The Jakarata Mail implementation was renamed to Angus Mail. With Angus Mail 2 the package names where changed from com.sun.mail.* to org.eclipse.angus.mail.*.

It would be nice if simple-java-mail was updated to use the latest Angus Mail release.

By the way: Thank you very much for providing simple-java-mail!

@vladimirfx
Copy link

I can provide a PR if needed.

@bbottema
Copy link
Owner

It's not that easy. You'd have to upgrade all upstream projects as well, like the smtp connection pool library. I'll deal with it.

@bbottema bbottema added Priority-Low dependencies Pull requests that update a dependency file labels Jan 17, 2024
@bbottema bbottema added this to the 8.6.0 milestone Jan 17, 2024
@vladimirfx
Copy link

OK. Now it is so painful to use SJM with the actual Spring Boot version. Thaks

bbottema added a commit that referenced this issue Jan 17, 2024
@bbottema
Copy link
Owner

Upgrade released in 8.6.0.

@PascalSchumacher
Copy link
Contributor Author

PascalSchumacher commented Jan 17, 2024

Thank you very much! 👍

@Faelean
Copy link

Faelean commented Jan 18, 2024

Looking at the dependency tree I've noticed one issue:
With the renaming to Angus Mail the Jakarta Activation was also renamed to Angus Activation. Right now Angus Activation is a dependency of the Core Module via Angus Mail.
The Outlook Module uses the Outlook Message Parser which still has Jakarta Activation as a dependency, so now I have both Angus and Jakarta Activation as dependencies.

@bbottema
Copy link
Owner

bbottema commented Jan 18, 2024

Good catch. I'll get on it. It's also in java-reflection and as a transitive of jakarta.xml.bind-api

@bbottema
Copy link
Owner

bbottema commented Jan 18, 2024

I got java-reflection sorted out, but jakarta.xml.bind-api 4.x.x -which internally updates to the Angus activation package- requires Java 11. Simple Java Mail is still on Java 8, since in 2023, still a third of all Java usage is Java 8 LTS. This is becoming a challenge.

bbottema added a commit that referenced this issue Jan 18, 2024
…cies as well. Also got rid of jakarta.xml.bind-api, which blocked the upgrade due to Java 11 requirement (but wasn't really needed anyway)
@bbottema bbottema modified the milestones: 8.6.0, 8.6.1 Jan 18, 2024
@bbottema
Copy link
Owner

Everything sorted out. Update released in 8.6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Priority-Low
Projects
None yet
Development

No branches or pull requests

4 participants